From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=41916 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PJ6lf-0003Ky-Q7
	for qemu-devel@nongnu.org; Thu, 18 Nov 2010 10:51:24 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Jes.Sorensen@redhat.com>) id 1PJ6ld-0006zW-RY
	for qemu-devel@nongnu.org; Thu, 18 Nov 2010 10:51:23 -0500
Received: from mx1.redhat.com ([209.132.183.28]:39275)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Jes.Sorensen@redhat.com>) id 1PJ6ld-0006zO-JI
	for qemu-devel@nongnu.org; Thu, 18 Nov 2010 10:51:21 -0500
Message-ID: <4CE54B74.8070405@redhat.com>
Date: Thu, 18 Nov 2010 16:51:16 +0100
From: Jes Sorensen <Jes.Sorensen@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [RFC][PATCH v3 01/21] virtproxy: base data structures
	and constants
References: <1289870175-14880-1-git-send-email-mdroth@linux.vnet.ibm.com>
	<1289870175-14880-2-git-send-email-mdroth@linux.vnet.ibm.com>
	<4CE508AA.7000405@redhat.com> <4CE547B8.7000309@linux.vnet.ibm.com>
	<4CE5492B.9060409@linux.vnet.ibm.com>
In-Reply-To: <4CE5492B.9060409@linux.vnet.ibm.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <aliguori@linux.vnet.ibm.com>
Cc: agl@linux.vnet.ibm.com, abeekhof@redhat.com, Michael Roth <mdroth@linux.vnet.ibm.com>, qemu-devel@nongnu.org, ryanh@us.ibm.com, amit.shah@redhat.com

On 11/18/10 16:41, Anthony Liguori wrote:
> On 11/18/2010 09:35 AM, Michael Roth wrote:
>>>> +/* listening fd, one for each service we're forwarding to remote
>>>> end */
>>>> +typedef struct VPOForward {
>>>> +    VPDriver *drv;
>>>> +    int listen_fd;
>>>> +    char service_id[VP_SERVICE_ID_LEN];
>>>> +    QLIST_ENTRY(VPOForward) next;
>>>> +} VPOForward;
>>>
>>> I am really not a fan of the typedefmeharder approach you are taking in
>>> here, but others may disagree with me.
>>
>> Isn't typedef'ing structured types part of the qemu coding style
>> guidelines?
> 
> Yes, I think Jes was just looking for an excuse to say "typedefmeharder"
> :-)

Actually typedefs are not listed as a must do thing in CODING_STYLE,
fortunately! It's just a really bad habit that is applied all over the
place in QEMU :(

http://www.linuxjournal.com/article/5780?page=0,2
search for typedef, for a lot of good reasoning why we shouldn't do this.

Jes