From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=56972 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PJ6rF-0007rr-0t for qemu-devel@nongnu.org; Thu, 18 Nov 2010 10:57:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PJ6rA-0008GQ-Ly for qemu-devel@nongnu.org; Thu, 18 Nov 2010 10:57:05 -0500 Received: from e8.ny.us.ibm.com ([32.97.182.138]:41144) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PJ6rA-0008GG-Jb for qemu-devel@nongnu.org; Thu, 18 Nov 2010 10:57:04 -0500 Received: from d01relay02.pok.ibm.com (d01relay02.pok.ibm.com [9.56.227.234]) by e8.ny.us.ibm.com (8.14.4/8.13.1) with ESMTP id oAIFduMn016214 for ; Thu, 18 Nov 2010 10:39:56 -0500 Received: from d03av06.boulder.ibm.com (d03av06.boulder.ibm.com [9.17.195.245]) by d01relay02.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id oAIFv2P5452776 for ; Thu, 18 Nov 2010 10:57:03 -0500 Received: from d03av06.boulder.ibm.com (loopback [127.0.0.1]) by d03av06.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id oAIG17Mv021238 for ; Thu, 18 Nov 2010 09:01:07 -0700 Message-ID: <4CE54CC1.2010808@linux.vnet.ibm.com> Date: Thu, 18 Nov 2010 09:56:49 -0600 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [RFC][PATCH v3 01/21] virtproxy: base data structures and constants References: <1289870175-14880-1-git-send-email-mdroth@linux.vnet.ibm.com> <1289870175-14880-2-git-send-email-mdroth@linux.vnet.ibm.com> <4CE508AA.7000405@redhat.com> <4CE547B8.7000309@linux.vnet.ibm.com> <4CE5492B.9060409@linux.vnet.ibm.com> <4CE54B74.8070405@redhat.com> In-Reply-To: <4CE54B74.8070405@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jes Sorensen Cc: agl@linux.vnet.ibm.com, abeekhof@redhat.com, Michael Roth , qemu-devel@nongnu.org, ryanh@us.ibm.com, amit.shah@redhat.com On 11/18/2010 09:51 AM, Jes Sorensen wrote: >> Yes, I think Jes was just looking for an excuse to say "typedefmeharder" >> :-) >> > Actually typedefs are not listed as a must do thing in CODING_STYLE, > fortunately! That's a bug in CODING_STYLE. typedefing structures is one of the core characteristics of QEMU coding style. Regards, Anthony Liguori > It's just a really bad habit that is applied all over the > place in QEMU :( > > http://www.linuxjournal.com/article/5780?page=0,2 > search for typedef, for a lot of good reasoning why we shouldn't do this. > > Jes >