From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=38158 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PJ7Fh-0004VA-F8 for qemu-devel@nongnu.org; Thu, 18 Nov 2010 11:22:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PJ7Fd-0005OH-Cz for qemu-devel@nongnu.org; Thu, 18 Nov 2010 11:22:24 -0500 Received: from mx1.redhat.com ([209.132.183.28]:33466) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PJ7Fd-0005Ny-6D for qemu-devel@nongnu.org; Thu, 18 Nov 2010 11:22:21 -0500 Message-ID: <4CE552B9.8060002@redhat.com> Date: Thu, 18 Nov 2010 17:22:17 +0100 From: Jes Sorensen MIME-Version: 1.0 Subject: Re: [Qemu-devel] [RFC][PATCH v3 11/21] virtproxy: add handler for control packet References: <1289870175-14880-1-git-send-email-mdroth@linux.vnet.ibm.com> <1289870175-14880-12-git-send-email-mdroth@linux.vnet.ibm.com> <4CE50F89.6040007@redhat.com> <4CE551D4.1090202@linux.vnet.ibm.com> In-Reply-To: <4CE551D4.1090202@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Roth Cc: agl@linux.vnet.ibm.com, abeekhof@redhat.com, qemu-devel@nongnu.org, aliguori@linux.vnet.ibm.com, ryanh@us.ibm.com, amit.shah@redhat.com On 11/18/10 17:18, Michael Roth wrote: > On 11/18/2010 05:35 AM, Jes Sorensen wrote: >> You should never have two closing braces in the same column like this - >> something is wrong with the formatting. > > That's from using a block for the case > switch () { > case: { > ... > } > } > > Alternative is to indent the "case:", which is "right" I think, but > aligning those with switch() seems to be pretty standard to conserve space. Why do you need braces around the case: { } ? That is not normally used throughout the code. Cheers, Jes