From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=48201 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PJ7gy-0001kn-P0 for qemu-devel@nongnu.org; Thu, 18 Nov 2010 11:50:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PJ7gx-0002Xn-NM for qemu-devel@nongnu.org; Thu, 18 Nov 2010 11:50:36 -0500 Received: from e7.ny.us.ibm.com ([32.97.182.137]:57080) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PJ7gx-0002XJ-Kn for qemu-devel@nongnu.org; Thu, 18 Nov 2010 11:50:35 -0500 Received: from d01relay05.pok.ibm.com (d01relay05.pok.ibm.com [9.56.227.237]) by e7.ny.us.ibm.com (8.14.4/8.13.1) with ESMTP id oAIGXfup006488 for ; Thu, 18 Nov 2010 11:33:41 -0500 Received: from d01av01.pok.ibm.com (d01av01.pok.ibm.com [9.56.224.215]) by d01relay05.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id oAIGoXdg141422 for ; Thu, 18 Nov 2010 11:50:33 -0500 Received: from d01av01.pok.ibm.com (loopback [127.0.0.1]) by d01av01.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id oAIGoXsm013185 for ; Thu, 18 Nov 2010 11:50:33 -0500 Message-ID: <4CE55958.7020004@linux.vnet.ibm.com> Date: Thu, 18 Nov 2010 10:50:32 -0600 From: Michael Roth MIME-Version: 1.0 Subject: Re: [Qemu-devel] [RFC][PATCH v3 11/21] virtproxy: add handler for control packet References: <1289870175-14880-1-git-send-email-mdroth@linux.vnet.ibm.com> <1289870175-14880-12-git-send-email-mdroth@linux.vnet.ibm.com> <4CE50F89.6040007@redhat.com> <4CE551D4.1090202@linux.vnet.ibm.com> <4CE552B9.8060002@redhat.com> In-Reply-To: <4CE552B9.8060002@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jes Sorensen Cc: agl@linux.vnet.ibm.com, abeekhof@redhat.com, qemu-devel@nongnu.org, aliguori@linux.vnet.ibm.com, ryanh@us.ibm.com, amit.shah@redhat.com On 11/18/2010 10:22 AM, Jes Sorensen wrote: > On 11/18/10 17:18, Michael Roth wrote: >> On 11/18/2010 05:35 AM, Jes Sorensen wrote: >>> You should never have two closing braces in the same column like this - >>> something is wrong with the formatting. >> >> That's from using a block for the case >> switch () { >> case: { >> ... >> } >> } >> >> Alternative is to indent the "case:", which is "right" I think, but >> aligning those with switch() seems to be pretty standard to conserve space. > > Why do you need braces around the case: { } ? That is not normally used > throughout the code. > I use them here to avoid declaring a bunch of variables may not be used depending on the case. Although, it might cleaner to use separate functions here instead. > Cheers, > Jes