From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roger Pau Monne Subject: Re: [PATCH 04/20] autoconf: New test for openpty et al. Date: Mon, 16 Apr 2012 11:40:36 +0100 Message-ID: <4CEB2412-545B-48A4-A6F2-52213D328565@citrix.com> References: <1334342414-10289-1-git-send-email-ian.jackson@eu.citrix.com> <1334342414-10289-5-git-send-email-ian.jackson@eu.citrix.com> <20363.62946.40242.576539@mariner.uk.xensource.com> Mime-Version: 1.0 (Apple Message framework v1257) Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <20363.62946.40242.576539@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org El 16/04/2012, a las 11:35, Ian Jackson escribi=F3: > Roger Pau Monne writes ("Re: [Xen-devel] [PATCH 04/20] autoconf: New test= for openpty et al."): >>> +#ifdef INCLUDE_LIBUTIL_H >>> +#include INCLUDE_LIBUTIL_H >>> +#endif >>> + >> = >> Maybe I'm missing something, because this autoconf macros are hard to re= ad, but shouldn't you add something like >> = >> #undef INCLUDE_LIBUTIL_H >> = >> to tools/config.h.in, so the generated config.h contains this define? > = > Yes. This is normally done by autoheader, which is normally done by > autogen.sh. But I see that we aren't running autoheader. I will see > about fixing that. > = Autoheader was adding a lot of stuff which we weren't using, so I preferred= to keep config.h.in (and config.h) with just the defines we really need.