From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCHv6 00/16] boot order specification Date: Sun, 28 Nov 2010 11:38:36 +0200 Message-ID: <4CF2231C.5000706@redhat.com> References: <1290012243-6087-1-git-send-email-gleb@redhat.com> <20101123153141.GD25606@redhat.com> <4CEBE7F4.9080200@linux.vnet.ibm.com> <4CF1706A.3000507@redhat.com> <20101128075404.GF6897@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Anthony Liguori , qemu-devel@nongnu.org, kvm@vger.kernel.org, blauwirbel@gmail.com, armbru@redhat.com, alex.williamson@redhat.com, mst@redhat.com, kevin@koconnor.net, Anthony Liguori To: Gleb Natapov Return-path: Received: from mx1.redhat.com ([209.132.183.28]:17567 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751824Ab0K1JjC (ORCPT ); Sun, 28 Nov 2010 04:39:02 -0500 In-Reply-To: <20101128075404.GF6897@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 11/28/2010 09:54 AM, Gleb Natapov wrote: > On Sat, Nov 27, 2010 at 10:56:10PM +0200, Avi Kivity wrote: > > On 11/23/2010 06:12 PM, Anthony Liguori wrote: > > >On 11/23/2010 09:31 AM, Gleb Natapov wrote: > > >>Anthony, Blue > > >> > > >>No comments on this patch series for almost a week. Can it be applied? > > > > > >Does that mean everyone's happy or have folks not gotten around to > > >review it? > > > > > >IOW, last call if you have objections :-) > > > > > > > I haven't reviewed this - I trust the author and maintainers to get > > it right. > > > > But I notice the there is no documentation - surely some is needed? > > > > The patch creates Openfirmware device path from qdev > hierarchy. Each element of a device path depends on type of a bus > the device resides on. You can find various bus bindings here: > http://playground.sun.com/1275/bindings/ and main spec is here > http://forthworks.com/standards/of1275.pdf. Format in which list of > device paths is passed to firmware is documented by comment (it is very > simple). The only thing missing is command line option documentation. I > will add it and resend if no more changes are needed for patch to be > excepted. What about the format of the fwcfg interface? It should be described, and point to the references above. -- error compiling committee.c: too many arguments to function From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=39693 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PMdio-0007y1-KF for qemu-devel@nongnu.org; Sun, 28 Nov 2010 04:39:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PMdin-0005JB-9r for qemu-devel@nongnu.org; Sun, 28 Nov 2010 04:39:02 -0500 Received: from mx1.redhat.com ([209.132.183.28]:4298) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PMdim-0005J7-Qr for qemu-devel@nongnu.org; Sun, 28 Nov 2010 04:39:01 -0500 Message-ID: <4CF2231C.5000706@redhat.com> Date: Sun, 28 Nov 2010 11:38:36 +0200 From: Avi Kivity MIME-Version: 1.0 References: <1290012243-6087-1-git-send-email-gleb@redhat.com> <20101123153141.GD25606@redhat.com> <4CEBE7F4.9080200@linux.vnet.ibm.com> <4CF1706A.3000507@redhat.com> <20101128075404.GF6897@redhat.com> In-Reply-To: <20101128075404.GF6897@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCHv6 00/16] boot order specification List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gleb Natapov Cc: Anthony Liguori , kvm@vger.kernel.org, mst@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com, blauwirbel@gmail.com, Anthony Liguori , alex.williamson@redhat.com, kevin@koconnor.net On 11/28/2010 09:54 AM, Gleb Natapov wrote: > On Sat, Nov 27, 2010 at 10:56:10PM +0200, Avi Kivity wrote: > > On 11/23/2010 06:12 PM, Anthony Liguori wrote: > > >On 11/23/2010 09:31 AM, Gleb Natapov wrote: > > >>Anthony, Blue > > >> > > >>No comments on this patch series for almost a week. Can it be applied? > > > > > >Does that mean everyone's happy or have folks not gotten around to > > >review it? > > > > > >IOW, last call if you have objections :-) > > > > > > > I haven't reviewed this - I trust the author and maintainers to get > > it right. > > > > But I notice the there is no documentation - surely some is needed? > > > > The patch creates Openfirmware device path from qdev > hierarchy. Each element of a device path depends on type of a bus > the device resides on. You can find various bus bindings here: > http://playground.sun.com/1275/bindings/ and main spec is here > http://forthworks.com/standards/of1275.pdf. Format in which list of > device paths is passed to firmware is documented by comment (it is very > simple). The only thing missing is command line option documentation. I > will add it and resend if no more changes are needed for patch to be > excepted. What about the format of the fwcfg interface? It should be described, and point to the references above. -- error compiling committee.c: too many arguments to function