From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=44813 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PPymL-00025t-MJ
	for qemu-devel@nongnu.org; Tue, 07 Dec 2010 09:44:31 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Jes.Sorensen@redhat.com>) id 1PPymK-0006AN-NL
	for qemu-devel@nongnu.org; Tue, 07 Dec 2010 09:44:29 -0500
Received: from mx1.redhat.com ([209.132.183.28]:17486)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Jes.Sorensen@redhat.com>) id 1PPymK-00069q-GS
	for qemu-devel@nongnu.org; Tue, 07 Dec 2010 09:44:28 -0500
Message-ID: <4CFE483C.5000308@redhat.com>
Date: Tue, 07 Dec 2010 15:44:12 +0100
From: Jes Sorensen <Jes.Sorensen@redhat.com>
MIME-Version: 1.0
References: <1291399402-20366-1-git-send-email-mdroth@linux.vnet.ibm.com>
	<1291399402-20366-21-git-send-email-mdroth@linux.vnet.ibm.com>
In-Reply-To: <1291399402-20366-21-git-send-email-mdroth@linux.vnet.ibm.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [RFC][PATCH v5 20/21] virtagent: integrate
 virtagent server/client via chardev
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Michael Roth <mdroth@linux.vnet.ibm.com>
Cc: agl@linux.vnet.ibm.com, stefanha@linux.vnet.ibm.com, abeekhof@redhat.com, qemu-devel@nongnu.org, aliguori@linux.vnet.ibm.com, ryanh@us.ibm.com

On 12/03/10 19:03, Michael Roth wrote:
> +#include "virtagent-common.h"
> +
> +static CharDriverState *qemu_chr_open_virtagent(QemuOpts *opts)
> +{
> +    CharDriverState *chr;
> +    int fd, ret;
> +
> +    /* revert to/enforce default socket chardev options for virtagent */
> +    if (qemu_opt_get(opts, "path") == NULL) {
> +        qemu_opt_set(opts, "path", "/tmp/virtagent-client.sock");
> +    }

More hardcoded paths, which you defined somewhere in a header already.
Again, please make it configurable.

> +    //qemu_opt_set(opts, "id", "virtagent");

If it isn't needed, please remove it.

Cheers,
Jes