From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: <4CFE86AC.9010801@codeaurora.org> Date: Tue, 07 Dec 2010 11:10:36 -0800 From: Stephen Boyd MIME-Version: 1.0 Subject: Re: [PATCH] drivers: char: hvc: add arm JTAG DCC console support References: <1291145141-18301-1-git-send-email-dwalker@codeaurora.org> <4CF5DD63.40803@codeaurora.org> <1291229696.14404.39.camel@c-dwalke-linux.qualcomm.com> <4CF6AE04.6030201@codeaurora.org> In-Reply-To: <4CF6AE04.6030201@codeaurora.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit To: Tony Lindgren Cc: Daniel Walker , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Arnd Bergmann , Nicolas Pitre , Greg Kroah-Hartman , Mike Frysinger , Andrew Morton , Alan Cox , Randy Dunlap , FUJITA Tomonori , linuxppc-dev@lists.ozlabs.org List-ID: On 12/01/2010 12:20 PM, Stephen Boyd wrote: > Definitely for TX since it seems like a redundant loop, but I agree RX > code has changed. Instead of > > If RX buffer full > Poll for RX buffer full > Read character from RX buffer > > we would have > > If RX buffer full > Read character from RX buffer > > which doesn't seem all that different assuming the RX buffer doesn't go > from full to empty between the If and Poll steps. Hopefully Tony knows more. > Tony, any thoughts? -- Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wolverine02.qualcomm.com (wolverine02.qualcomm.com [199.106.114.251]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "wolverine02.qualcomm.com", Issuer "VeriSign Class 3 Secure Server CA" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 265D6B708B for ; Wed, 8 Dec 2010 06:10:40 +1100 (EST) Message-ID: <4CFE86AC.9010801@codeaurora.org> Date: Tue, 07 Dec 2010 11:10:36 -0800 From: Stephen Boyd MIME-Version: 1.0 To: Tony Lindgren Subject: Re: [PATCH] drivers: char: hvc: add arm JTAG DCC console support References: <1291145141-18301-1-git-send-email-dwalker@codeaurora.org> <4CF5DD63.40803@codeaurora.org> <1291229696.14404.39.camel@c-dwalke-linux.qualcomm.com> <4CF6AE04.6030201@codeaurora.org> In-Reply-To: <4CF6AE04.6030201@codeaurora.org> Content-Type: text/plain; charset=UTF-8 Cc: Randy Dunlap , Daniel Walker , Mike Frysinger , Arnd Bergmann , Nicolas Pitre , linux-arm-msm@vger.kernel.org, Greg Kroah-Hartman , linux-kernel@vger.kernel.org, FUJITA Tomonori , Andrew Morton , linuxppc-dev@lists.ozlabs.org, Alan Cox List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 12/01/2010 12:20 PM, Stephen Boyd wrote: > Definitely for TX since it seems like a redundant loop, but I agree RX > code has changed. Instead of > > If RX buffer full > Poll for RX buffer full > Read character from RX buffer > > we would have > > If RX buffer full > Read character from RX buffer > > which doesn't seem all that different assuming the RX buffer doesn't go > from full to empty between the If and Poll steps. Hopefully Tony knows more. > Tony, any thoughts? -- Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.