From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=51381 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PUPJT-00012z-DU
	for qemu-devel@nongnu.org; Sun, 19 Dec 2010 14:53:00 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <breuerr@mc.net>) id 1PUPJS-0000K7-56
	for qemu-devel@nongnu.org; Sun, 19 Dec 2010 14:52:59 -0500
Received: from mail.mc.net ([209.172.128.24]:51074)
	by eggs.gnu.org with smtp (Exim 4.71)
	(envelope-from <breuerr@mc.net>) id 1PUPJR-0000Jg-Vl
	for qemu-devel@nongnu.org; Sun, 19 Dec 2010 14:52:58 -0500
Message-ID: <4D0E6448.7070006@mc.net>
Date: Sun, 19 Dec 2010 14:00:08 -0600
From: Bob Breuer <breuerr@mc.net>
MIME-Version: 1.0
References: <4D0CEAB0.9030706@mc.net>	<AANLkTi=uo-7La8+XxVV3UcEkX3nuT++AazrUTcnTSf9_@mail.gmail.com>	<D9A98D39-A945-4D14-AB4C-D872D27CBE2F@web.de>
	<4D0E5F16.3090905@mc.net>
In-Reply-To: <4D0E5F16.3090905@mc.net>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] [PATCH] sparc32: ledma extra registers need tracing too
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: QEMU Developers <qemu-devel@nongnu.org>
Cc: Blue Swirl <blauwirbel@gmail.com>, =?ISO-8859-1?Q?Andreas_F=E4rber?= <andreas.faerber@web.de>

Also trace the extra registers, and call them undocumented instead.

Signed-off-by: Bob Breuer <breuerr@mc.net>

diff --git a/hw/sparc32_dma.c b/hw/sparc32_dma.c
index 56be8c8..0325a55 100644
--- a/hw/sparc32_dma.c
+++ b/hw/sparc32_dma.c
@@ -170,7 +170,9 @@ static uint32_t dma_mem_readl(void *opaque, target_phys_addr_t addr)
     uint32_t saddr;
 
     if (s->is_ledma && (addr > DMA_MAX_REG_OFFSET)) {
-        return 0; /* extra mystery register(s) */
+        /* extra undocumented register(s) */
+        trace_sparc32_dma_mem_readl(addr, 0);
+        return 0;
     }
     saddr = (addr & DMA_MASK) >> 2;
     trace_sparc32_dma_mem_readl(addr, s->dmaregs[saddr]);
@@ -183,7 +185,9 @@ static void dma_mem_writel(void *opaque, target_phys_addr_t addr, uint32_t val)
     uint32_t saddr;
 
     if (s->is_ledma && (addr > DMA_MAX_REG_OFFSET)) {
-        return; /* extra mystery register(s) */
+        /* extra undocumented register(s) */
+        trace_sparc32_dma_mem_writel(addr, 0, val);
+        return;
     }
     saddr = (addr & DMA_MASK) >> 2;
     trace_sparc32_dma_mem_writel(addr, s->dmaregs[saddr], val);