On 12/08/2010 06:35 PM, Lei Yu wrote: > --- > Makefile.am | 3 +- > src/cdma-sms.c | 342 ++++++++++++++++++++++++++++++++++++++ > src/cdma-smsutil.c | 467 ++++++++++++++++++++++++++++++++++++++++++++++++++++ > src/cdma-smsutil.h | 264 +++++++++++++++++++++++++++++ Please break this up into two patches, one for atom implementation (along with ofono.h change from Patch 1) and the utilities in a separate patch. Otherwise it becomes a wee bit too big to handle ;) Regards, -Denis