Hi Denis Thank you for reviewing these patches. I will submit new versions for your comments, please see any open points inline. On 12/20/2010 12:50 PM, ext Denis Kenzior wrote: >> + */ >> + >> +#ifndef __OFONO_CDMA_VOICECALL_H >> +#define __OFONO_CDMA_VOICECALL_H >> + >> +#ifdef __cplusplus >> +extern "C" { >> +#endif >> + >> +#include >> + >> +struct ofono_cdma_voicecall_manager; > > Please call this ofono_cdma_voicecall. This is actually our preference as well as there is no multicall in CDMA, just the single voicecall. To that end, does it not make sense to also rename the interface "Voicecall" rather than "VoiceCallManager"? Cheers Dara