From: f6bvp <f6bvp@free.fr>
To: ralf@linux-mips.org
Cc: linux-hams@vger.kernel.org, Bernard Pidoux <bernard.pidoux@upmc.fr>
Subject: Can AX25 socket debug message be removed ?
Date: Tue, 21 Dec 2010 11:38:25 +0100 [thread overview]
Message-ID: <4D1083A1.209@free.fr> (raw)
In-Reply-To: <4CF78B70.4060907@free.fr>
[-- Attachment #1: Type: text/plain, Size: 334 bytes --]
Hi Ralf,
I would like to know your thinking about removing the following
kernel debug messages that fills /var/log/kernel/info and does not
seem to be actually usefull.
I build a patch project included here.
In case you approve I will submit it.
Should the SOCK_DEBUG lines be commented or removed ?
Bernard Pidoux <f6bvp@free.fr>
[-- Attachment #2: af_ax25_sock_debug.patch --]
[-- Type: text/x-patch, Size: 1523 bytes --]
--- a/net/ax25/af_ax25.c 2010-12-09 23:17:27.000000000 +0100
+++ b/net/ax25/af_ax25.c 2010-11-17 17:49:41.414197280 +0100
@@ -1538,7 +1538,7 @@
}
/* Build a packet */
- SOCK_DEBUG(sk, "AX.25: sendto: Addresses built. Building packet.\n");
+/* SOCK_DEBUG(sk, "AX.25: sendto: Addresses built. Building packet.\n");*/
/* Assume the worst case */
size = len + ax25->ax25_dev->dev->hard_header_len;
@@ -1549,7 +1549,7 @@
skb_reserve(skb, size - len);
- SOCK_DEBUG(sk, "AX.25: Appending user data\n");
+/* SOCK_DEBUG(sk, "AX.25: Appending user data\n");*/
/* User data follows immediately after the AX.25 data */
if (memcpy_fromiovec(skb_put(skb, len), msg->msg_iov, len)) {
@@ -1564,7 +1564,7 @@
if (!ax25->pidincl)
*skb_push(skb, 1) = sk->sk_protocol;
- SOCK_DEBUG(sk, "AX.25: Transmitting buffer\n");
+/* SOCK_DEBUG(sk, "AX.25: Transmitting buffer\n");*/
if (sk->sk_type == SOCK_SEQPACKET) {
/* Connected mode sockets go via the LAPB machine */
@@ -1583,7 +1583,7 @@
skb_push(skb, 1 + ax25_addr_size(dp));
- SOCK_DEBUG(sk, "Building AX.25 Header (dp=%p).\n", dp);
+/* SOCK_DEBUG(sk, "Building AX.25 Header (dp=%p).\n", dp);*/
if (dp != NULL)
SOCK_DEBUG(sk, "Num digipeaters=%d\n", dp->ndigi);
@@ -1592,7 +1592,7 @@
lv = ax25_addr_build(skb->data, &ax25->source_addr, &sax.sax25_call,
dp, AX25_COMMAND, AX25_MODULUS);
- SOCK_DEBUG(sk, "Built header (%d bytes)\n",lv);
+/* SOCK_DEBUG(sk, "Built header (%d bytes)\n",lv);*/
skb_set_transport_header(skb, lv);
next prev parent reply other threads:[~2010-12-21 10:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-02 12:05 [PATCH] [ROSE] AX25 packet routing improvement f6bvp
2010-12-20 18:11 ` f6bvp
2011-01-21 11:23 ` f6bvp
2010-12-21 10:38 ` f6bvp [this message]
2010-12-21 17:33 ` Can AX25 socket debug message be removed ? Ralf Baechle DL5RB
2010-12-22 9:43 ` Bernard Pidoux F6BVP
2011-02-15 14:25 ` f6bvp
2010-12-21 10:41 ` Can ROSE " Bernard Pidoux
2011-02-14 17:52 ` [PATCH] [ROSE] AX25 packet routing improvement Bernard Pidoux
2011-02-14 21:35 ` David Miller
2011-07-17 13:51 Can AX25 socket debug message be removed ? Bernard Pidoux
2011-07-18 15:17 ` Ralf Baechle
[not found] <4E22E1DD.2060902@upmc.fr>
2011-07-18 15:07 ` Ralf Baechle
2011-07-18 19:39 ` Bernard Pidoux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D1083A1.209@free.fr \
--to=f6bvp@free.fr \
--cc=bernard.pidoux@upmc.fr \
--cc=linux-hams@vger.kernel.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.