From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=56510 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Pc41C-00065n-Bp
	for qemu-devel@nongnu.org; Sun, 09 Jan 2011 17:45:47 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1Pc417-0006sJ-DM
	for qemu-devel@nongnu.org; Sun, 09 Jan 2011 17:45:46 -0500
Received: from mail-iy0-f173.google.com ([209.85.210.173]:58666)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1Pc417-0006sF-99
	for qemu-devel@nongnu.org; Sun, 09 Jan 2011 17:45:41 -0500
Received: by iye19 with SMTP id 19so18984575iye.4
	for <qemu-devel@nongnu.org>; Sun, 09 Jan 2011 14:45:40 -0800 (PST)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <4D2A3A90.8020703@twiddle.net>
Date: Sun, 09 Jan 2011 14:45:36 -0800
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 1/7] tcg: Define "deposit" as an optional
	operation.
References: <1294440183-885-1-git-send-email-rth@twiddle.net>	<1294440183-885-2-git-send-email-rth@twiddle.net>
	<20110109213855.GA17026@hall.aurel32.net>
In-Reply-To: <20110109213855.GA17026@hall.aurel32.net>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>

On 01/09/2011 01:38 PM, Aurelien Jarno wrote:
> The encoding of the constant part actually doesn't match the one in the
> C function where two arguments are separated and not encoded. What about
> adding a tcg_gen_op5ii_i32/64 function and having the two arguments
> separated?

I certainly didn't want to expose the combined argument to the target
translators.  I had thought that saving some memory by combining the
two constants would be a good idea, but perhaps you're right that it's
overly complicated for the benefit.

> Also what about a shorter name, like for example 'dep' as it is used on
> some architectures.

I suppose.  I thought perhaps that would be too cryptic though.


r~