From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state Date: Mon, 10 Jan 2011 23:21:22 +0100 Message-ID: <4D2B8662.9060909@web.de> References: <4D2B6CB5.9050602@codemonkey.ws> <4D2B74D8.4080309@web.de> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigAB76A1808625BBB8B3FE296F" Cc: Marcelo Tosatti , Anthony Liguori , Glauber Costa , qemu-devel@nongnu.org, kvm@vger.kernel.org To: Anthony Liguori Return-path: Received: from fmmailgate01.web.de ([217.72.192.221]:45775 "EHLO fmmailgate01.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754618Ab1AJWVa (ORCPT ); Mon, 10 Jan 2011 17:21:30 -0500 In-Reply-To: <4D2B74D8.4080309@web.de> Sender: kvm-owner@vger.kernel.org List-ID: This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigAB76A1808625BBB8B3FE296F Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Am 10.01.2011 22:06, Jan Kiszka wrote: >> kvmclock should be created with >> kvm_state as a parameter and kvm_vm_ioctl() is passed the stored >> reference. Taking a global reference to kvm_state in machine_init is= >> not a bad thing, obviously the machine initialization function needs >> access to the kvm_state. >=20 > This would also require changing sysbus interfaces for the sake of KVM'= s > "abstraction". If this is the only way forward, I could look into this.= Actually, there is already a channel to pass pointers to qdev devices: the pointer property hack. I'm not sure we should contribute to its user base or take the chance for a cleanup, but we are not alone with this requirement. Point below remains valid, though. >=20 > Still, I do not see any benefit for the affected code. You then either > need to "steal" a kvm_state reference from the first cpu or introduce a= > marvelous interface like kvm_get_state() to make this work from outside= > of the KVM core. >=20 Jan --------------enigAB76A1808625BBB8B3FE296F Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.15 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org/ iEYEARECAAYFAk0rhmcACgkQitSsb3rl5xQgjQCg3PtZBEH6xJ7mcOrxwc4vFXdf 7YQAmQFXslIiwibDbUbAjz4jVz4kbB4R =Jnna -----END PGP SIGNATURE----- --------------enigAB76A1808625BBB8B3FE296F-- From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=45383 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PcQEN-0003iZ-NU for qemu-devel@nongnu.org; Mon, 10 Jan 2011 17:29:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PcQ7G-0004hU-Lh for qemu-devel@nongnu.org; Mon, 10 Jan 2011 17:21:31 -0500 Received: from fmmailgate01.web.de ([217.72.192.221]:45774) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PcQ7G-0004h3-AH for qemu-devel@nongnu.org; Mon, 10 Jan 2011 17:21:30 -0500 Message-ID: <4D2B8662.9060909@web.de> Date: Mon, 10 Jan 2011 23:21:22 +0100 From: Jan Kiszka MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state References: <4D2B6CB5.9050602@codemonkey.ws> <4D2B74D8.4080309@web.de> In-Reply-To: <4D2B74D8.4080309@web.de> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigAB76A1808625BBB8B3FE296F" Sender: jan.kiszka@web.de List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Anthony Liguori , Marcelo Tosatti , Glauber Costa , kvm@vger.kernel.org, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigAB76A1808625BBB8B3FE296F Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Am 10.01.2011 22:06, Jan Kiszka wrote: >> kvmclock should be created with >> kvm_state as a parameter and kvm_vm_ioctl() is passed the stored >> reference. Taking a global reference to kvm_state in machine_init is= >> not a bad thing, obviously the machine initialization function needs >> access to the kvm_state. >=20 > This would also require changing sysbus interfaces for the sake of KVM'= s > "abstraction". If this is the only way forward, I could look into this.= Actually, there is already a channel to pass pointers to qdev devices: the pointer property hack. I'm not sure we should contribute to its user base or take the chance for a cleanup, but we are not alone with this requirement. Point below remains valid, though. >=20 > Still, I do not see any benefit for the affected code. You then either > need to "steal" a kvm_state reference from the first cpu or introduce a= > marvelous interface like kvm_get_state() to make this work from outside= > of the KVM core. >=20 Jan --------------enigAB76A1808625BBB8B3FE296F Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.15 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org/ iEYEARECAAYFAk0rhmcACgkQitSsb3rl5xQgjQCg3PtZBEH6xJ7mcOrxwc4vFXdf 7YQAmQFXslIiwibDbUbAjz4jVz4kbB4R =Jnna -----END PGP SIGNATURE----- --------------enigAB76A1808625BBB8B3FE296F--