From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel De Graaf Subject: Re: [PATCH 2/7] xen-gntdev: Change page limit to be global instead of per-open Date: Tue, 11 Jan 2011 07:45:34 -0500 Message-ID: <4D2C50EE.8010200@tycho.nsa.gov> References: <1292545063-32107-1-git-send-email-dgdegra@tycho.nsa.gov> <1292545063-32107-3-git-send-email-dgdegra@tycho.nsa.gov> <20110110215245.GD15016@dumpdata.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20110110215245.GD15016@dumpdata.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Konrad Rzeszutek Wilk Cc: jeremy@goop.org, xen-devel@lists.xensource.com, Ian.Campbell@citrix.com List-Id: xen-devel@lists.xenproject.org On 01/10/2011 04:52 PM, Konrad Rzeszutek Wilk wrote: >> static long gntdev_ioctl(struct file *flip, >> unsigned int cmd, unsigned long arg) >> { >> @@ -555,9 +538,6 @@ static long gntdev_ioctl(struct file *flip, >> case IOCTL_GNTDEV_GET_OFFSET_FOR_VADDR: >> return gntdev_ioctl_get_offset_for_vaddr(priv, ptr); >> >> - case IOCTL_GNTDEV_SET_MAX_GRANTS: >> - return gntdev_ioctl_set_max_grants(priv, ptr); > > Would it make sense to return -EPNOTSUPPORTED? Or does it not really > matter as nobody has been using this ioctl call? Does this produce a clearer error message than the default -ENOIOCTLCMD? It's possible that some people use it, since it was exposed as an API. Doesn't really matter to me; we could also have it return 0 and be a noop in case someone interprets its failure as inability to support a sufficient number of grants. >> - >> default: >> if (debug) >> printk("%s: priv %p, unknown cmd %x\n", >> -- >> 1.7.2.3 >> >> >> _______________________________________________ >> Xen-devel mailing list >> Xen-devel@lists.xensource.com >> http://lists.xensource.com/xen-devel >