From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=52154 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Pch9x-0004oL-FK for qemu-devel@nongnu.org; Tue, 11 Jan 2011 11:33:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Pch9n-0004gZ-Mf for qemu-devel@nongnu.org; Tue, 11 Jan 2011 11:33:20 -0500 Received: from a.mail.sonic.net ([64.142.16.245]:60998) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Pch9n-0004fr-Ca for qemu-devel@nongnu.org; Tue, 11 Jan 2011 11:33:15 -0500 Message-ID: <4D2C8639.9000903@twiddle.net> Date: Tue, 11 Jan 2011 08:32:57 -0800 From: Richard Henderson MIME-Version: 1.0 References: <1294716228-9299-1-git-send-email-rth@twiddle.net> <1294716228-9299-3-git-send-email-rth@twiddle.net> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 2/7] tcg-ppc: Implement deposit operation. List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: malc Cc: qemu-devel@nongnu.org, aurelien@aurel32.net, agraf@suse.de On 01/11/2011 04:40 AM, malc wrote: >> + tcg_out32 (s, RLWIMI >> + | RA(args[0]) >> + | RS(args[2]) >> + | SH(lsb_ofs) >> + | MB(msb_ofs - len + 1) >> + | ME(msb_ofs)); >> + } ... >> + { INDEX_op_deposit_i32, { "r", "0", "r" } }, >> > > Are you sure about "0" constraint? Yes, rlwimi inserts a value into the destination register. There is no second source register for the instruction. r~