From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel De Graaf <dgdegra@tycho.nsa.gov>
Subject: Re: [PATCH libxc] Remove set_max_grants in linux
Date: Wed, 12 Jan 2011 12:57:46 -0500
Message-ID: <4D2DEB9A.9070500@tycho.nsa.gov>
References: <1292545063-32107-1-git-send-email-dgdegra@tycho.nsa.gov>	<1292545063-32107-3-git-send-email-dgdegra@tycho.nsa.gov>	<20110110215245.GD15016@dumpdata.com>	<4D2C50EE.8010200@tycho.nsa.gov>	<20110111175146.GG14017@dumpdata.com>	<4D2C9EE1.4010705@tycho.nsa.gov>	<20110111182137.GA29223@dumpdata.com>	<4D2CA61C.2060306@tycho.nsa.gov>
	<19757.57897.295979.150921@mariner.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <19757.57897.295979.150921@mariner.uk.xensource.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: jeremy@goop.org, xen-devel@lists.xensource.com, Ian.Campbell@citrix.com, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
List-Id: xen-devel@lists.xenproject.org

On 01/12/2011 12:17 PM, Ian Jackson wrote:
> Daniel De Graaf writes ("[Xen-devel] [PATCH libxc] Remove set_max_grants in linux"):
>> I just removed the linux version, because I didn't want to prevent its use
>> in minios where it is needed to resize the array of grants.
>>
>> ------------------------------------------------------------------->8
>>
>> The maximum number of grants is now constrained domain-wide in linux,
>> so set_max_grants should be a noop there. Previously, this constraint
>> was per-file-description.
> 
> Is this unconditional change suitable for putting into xen-unstable.hg
> for the 4.1 release ?  In particular, will it break compatibility with
> "traditional Xen" kernels ?
> 
> Ian.
> 

It won't break compatibility; Linux has never required that you set the
limit in order to use grants. The default limit is set to the maximum
possible limit, so existing users cannot have been increasing it;
changing a possible decrease to a noop shouldn't break anything sane.

-- 
Daniel De Graaf
National Security Agency