From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergey Tovpeko Subject: xl and GFX passthrough Date: Thu, 13 Jan 2011 12:12:45 +0300 Message-ID: <4D2EC20D.2050603@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------040500040609020506040706" Return-path: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org This is a multi-part message in MIME format. --------------040500040609020506040706 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hello, everybody! I knew recently that xl doesn't yet work with GFX passthrough for HVM guest. It makes me consider that main job for GFX passthrough are going for xm toolstack. My company is very interested to use xl tool, but we need also GFX passthrough. The issue is not very hard to solve. It just needs to teach xl to recognize 'gfx_passthru' in config file and pass it to qemu-dm. And qemu-dm will choose the specific VGA bios to load into domain's memory in case of this option. I attached the patch, addressing this issue. Please, consider to push it to main repository. Thank you. Sergey. --------------040500040609020506040706 Content-Type: text/x-patch; name="xl_gfx_passthru.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="xl_gfx_passthru.patch" commit 2692d4133b93260aabb7bad438a0c288238d1295 Author: Sergey Tovpeko Date: Fri Jul 9 20:33:39 2010 +0400 Pass gfx_passthru option to the device_model. To enable gfx passthru, xl should parse 'gfx_passthru' parameter from config file, and pass it to qemu-dm. diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c index 2c3fb0f..c630193 100644 --- a/tools/libxl/libxl.c +++ b/tools/libxl/libxl.c @@ -1208,6 +1208,11 @@ static char ** libxl_build_device_model_args_old(libxl__gc *gc, flexarray_set(dm_args, num++, "-vcpu_avail"); flexarray_set(dm_args, num++, libxl__sprintf(gc, "0x%x", info->vcpu_avail)); } + if (info->gfx_passthru) { + flexarray_set(dm_args, num++, "-gfx_passthru"); + flexarray_set(dm_args, num++, libxl__sprintf(gc, "%d", info->gfx_passthru)); + } + for (i = 0; i < num_vifs; i++) { if (vifs[i].nictype == NICTYPE_IOEMU) { char *smac = libxl__sprintf(gc, "%02x:%02x:%02x:%02x:%02x:%02x", diff --git a/tools/libxl/libxl.idl b/tools/libxl/libxl.idl index 81fcfd9..bf3c429 100644 --- a/tools/libxl/libxl.idl +++ b/tools/libxl/libxl.idl @@ -96,6 +96,7 @@ libxl_domain_build_info = Struct("domain_build_info",[ ("disable_migrate", bool), ("kernel", libxl_file_reference), ("cpuid", libxl_cpuid_policy_list), + ("gfx_passthru", integer), ("hvm", integer), ("u", KeyedUnion(None, "hvm", [("hvm", "%s", Struct(None, @@ -161,6 +162,7 @@ libxl_device_model_info = Struct("device_model_info",[ ("vcpu_avail", integer, False, "vcpus actually available"), ("xen_platform_pci", integer, False, "enable/disable the xen platform pci device"), ("extra", libxl_string_list, False, "extra parameters pass directly to qemu, NULL terminated"), + ("gfx_passthru", integer), ], comment= """Device Model information. diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c index 1eace78..415b9b8 100644 --- a/tools/libxl/xl_cmdimpl.c +++ b/tools/libxl/xl_cmdimpl.c @@ -363,6 +363,7 @@ static void init_dm_info(libxl_device_model_info *dm_info, dm_info->apic = b_info->u.hvm.apic; dm_info->vcpus = b_info->max_vcpus; dm_info->vcpu_avail = b_info->cur_vcpus; + dm_info->gfx_passthru = b_info->gfx_passthru; dm_info->stdvga = 0; dm_info->vnc = 1; @@ -900,6 +901,9 @@ static void parse_config_data(const char *configfile_filename_report, xlu_cfg_replace_string (config, "kernel", &b_info->kernel.path); + if (!xlu_cfg_get_long (config, "gfx_passthru", &l)) + b_info->gfx_passthru = l; + if (c_info->hvm == 1) { if (!xlu_cfg_get_long (config, "pae", &l)) b_info->u.hvm.pae = l; --------------040500040609020506040706 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --------------040500040609020506040706--