From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergey Tovpeko Subject: Re: xl and GFX passthrough Date: Thu, 13 Jan 2011 14:17:57 +0300 Message-ID: <4D2EDF65.6080002@gmail.com> References: <4D2EC20D.2050603@gmail.com> <1294910794.8240.9.camel@zakaz.uk.xensource.com> <4D2ECE5A.8070807@gmail.com> <1294914282.8240.38.camel@zakaz.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1294914282.8240.38.camel@zakaz.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Ian Campbell , Daniel De Graaf Cc: "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org > > I just noticed that this appears to have been fixed by Daniel De Graf > just a few days ago, see 22711:4f6fee3a456e, which may only be in the > staging tree at http://xenbits.xen.org/staging/xen-unstable.hg since we > are waiting for a test pass. > > Ian, Daniel my patch is almost like Daniel's one. Thank you for pointing to it. And there's one absent thing in Daniel's commit (4f6fee3a456e). To complete the gfx passthrough issue for xl we should pass this option to qemu-dm, like this : + if (info->gfx_passthru) { + flexarray_set(dm_args, num++, "-gfx_passthru"); + flexarray_set(dm_args, num++, libxl__sprintf(gc, "%d", info->gfx_passthru)); + } I suppose, without it 'qemu-dm' won't know about gfx_passthru mode and won't load passthru'ed vga bios. Daniel might plan to add this code or added it already?