From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=34319 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Pf7YC-0006xU-Cd
	for qemu-devel@nongnu.org; Tue, 18 Jan 2011 04:08:29 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1Pf7YA-0004zi-9B
	for qemu-devel@nongnu.org; Tue, 18 Jan 2011 04:08:28 -0500
Received: from mx1.redhat.com ([209.132.183.28]:33709)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1Pf7YA-0004z3-1F
	for qemu-devel@nongnu.org; Tue, 18 Jan 2011 04:08:26 -0500
Message-ID: <4D35587F.3050503@redhat.com>
Date: Tue, 18 Jan 2011 10:08:15 +0100
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <1292879604-22268-1-git-send-email-agraf@suse.de>
	<1292879604-22268-9-git-send-email-agraf@suse.de>
	<4D34542D.7080301@siemens.com> <4D3467B9.3070207@suse.de>
	<4D346834.8000903@siemens.com> <4D3468A0.3060709@suse.de>
	<4D346C31.8060300@siemens.com> <4D346F5B.7090502@suse.de>
In-Reply-To: <4D346F5B.7090502@suse.de>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 8/8] ahci: fix !msi interrupts
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: Kevin Wolf <kwolf@redhat.com>, Jan Kiszka <jan.kiszka@siemens.com>, Sebastian Herbszt <herbszt@gmx.de>, qemu-devel Developers <qemu-devel@nongnu.org>, Joerg Roedel <Joerg.Roedel@amd.com>

   Hi,

>> Worse might also be that unknown issue that force you to inject an IRQ
>> here. We don't know. That's probably worst.
>
> Well, IIRC the issue was that usually a level high interrupt line would
> simply retrigger an interrupt after enabling the interrupt line in the
> APIC again.

edge triggered interrupts wouldn't though.

> Unless my memory completely fails on me, that didn't happen,
> so I added the manual retrigger on a partial command ACK in ahci code.

That re-trigger smells like you are not clearing the interrupt line 
where you should.  For starters try calling ahci_check_irq() after guest 
writes to PORT_IRQ_STAT.

cheers,
   Gerd