From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=33885 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PfAbJ-0006ZS-20 for qemu-devel@nongnu.org; Tue, 18 Jan 2011 07:23:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PfAbH-0002op-K7 for qemu-devel@nongnu.org; Tue, 18 Jan 2011 07:23:52 -0500 Received: from mx1.redhat.com ([209.132.183.28]:64119) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PfAbH-0002oP-Cs for qemu-devel@nongnu.org; Tue, 18 Jan 2011 07:23:51 -0500 Message-ID: <4D3586AE.8010509@redhat.com> Date: Tue, 18 Jan 2011 13:25:18 +0100 From: Kevin Wolf MIME-Version: 1.0 References: <1292879604-22268-1-git-send-email-agraf@suse.de> <1292879604-22268-4-git-send-email-agraf@suse.de> In-Reply-To: <1292879604-22268-4-git-send-email-agraf@suse.de> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 3/8] ahci: send init d2h fis on fis enable List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: Joerg Roedel , Gerd Hoffmann , qemu-devel Developers , Sebastian Herbszt Am 20.12.2010 22:13, schrieb Alexander Graf: > The drive sends a d2h init fis on initialization. Usually, the guest doesn't > receive fises yet at that point though, so the delivery is deferred. > > Let's reflect that by sending the init fis on fis receive enablement. > > Signed-off-by: Alexander Graf Hm... If I read the spec right, the real solution wouldn't be an init_d2h_sent flag, but implementing a queue for FISes that are received when the guest hasn't set FRE yet. I'm not against taking a hack like this, but maybe leave a comment somewhere at least. Kevin