From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=47989 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PfaG2-0005Wv-DQ for qemu-devel@nongnu.org; Wed, 19 Jan 2011 10:47:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PfaG0-0002Mr-I2 for qemu-devel@nongnu.org; Wed, 19 Jan 2011 10:47:38 -0500 Received: from mx1.redhat.com ([209.132.183.28]:32133) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PfaG0-0002MC-A9 for qemu-devel@nongnu.org; Wed, 19 Jan 2011 10:47:36 -0500 Message-ID: <4D3707F0.3050608@redhat.com> Date: Wed, 19 Jan 2011 16:49:04 +0100 From: Kevin Wolf MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 1/3] block: add resize monitor command References: <20110114162044.GA19114@lst.de> <20110114162057.GA19184@lst.de> <4D347E0F.4040000@redhat.com> <20110119153544.GA6987@lst.de> In-Reply-To: <20110119153544.GA6987@lst.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christoph Hellwig Cc: qemu-devel@nongnu.org, Luiz Capitulino Am 19.01.2011 16:35, schrieb Christoph Hellwig: > On Mon, Jan 17, 2011 at 06:36:15PM +0100, Kevin Wolf wrote: >>> + .args_type = "id:s,size:l", >> >> size should be 'o' instead of 'l'. The latter may be too small on 32 bit >> hosts and doesn't support convenient suffixes: > > o actually fails for 2GB or more for me: > > (qemu) resize scratch 2047 > resize scratch 2047 > (qemu) > (qemu) resize scrarch 2048 > resize scrarch 2048 > invalid size > > for l these worked fine. Hm, yeah, 'o' uses ssize_t instead of int64_t, so it's broken on a 32 bit host as well. Though I assume that you use a 64 bit host, and I can't really see what's the problem there... Kevin