From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] Adding support for MX35
Date: Thu, 20 Jan 2011 11:50:47 +0100 [thread overview]
Message-ID: <4D381387.50904@denx.de> (raw)
In-Reply-To: <20110120095231.7F5E9D301D7@gemini.denx.de>
On 01/20/2011 10:52 AM, Wolfgang Denk wrote:
> Dear Stefano Babic,
>
> In message <1295513194-16158-1-git-send-email-sbabic@denx.de> you wrote:
>> Patchset V2 contain patches for SPI sent previously independently to ML
>> and additional patches for I2C.
>
> I just learned that I was running an old version of checkpatch, which
> turned out some false positives (and my short visual inspection did
> not recognize this)
>
> Sorry for the flase alarms.
No problem, this explains the the different results. I ran checkpatch on
the patchset.
>
> The remaining warnings are:
>
> [U-Boot] [PATCH V2 01/11] Add support for MX35 processor
> total: 0 errors, 8 warnings, 2109 lines checked
They are related to typedef (mmmhh...there is one regarding usage of
volatile, I will fix it). I do not think that using typedef is forbidden.
>
> [U-Boot] [PATCH V2 04/11] I2C: mxc_i2c: get rid of __REG access
> total: 0 errors, 2 warnings, 169 lines checked
__FUNCTION__, I will fix it
>
> [U-Boot] [PATCH V2 05/11] I2C: mxc_i2c: address failure with mx35
> total: 1 errors, 1 warnings, 166 lines checked
See my previous comment. In any case, I will change to avoid checkpatch
complains
>
> [U-Boot] [PATCH V2 08/11] SPI: mxc_spi: fix swapping bug and add
> total: 0 errors, 1 warnings, 22 lines checked
Braces, braces...do you agree to follow checkpatch's rule (no braces for
single statement) ?
>
> [U-Boot] [PATCH V2 11/11] Add support for Freescale's mx35pdk board.
> total: 0 errors, 1 warnings, 1331 lines checked
You already give me the solution
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================
next prev parent reply other threads:[~2011-01-20 10:50 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-20 8:46 [U-Boot] Adding support for MX35 Stefano Babic
2011-01-20 8:46 ` [U-Boot] [PATCH V2 01/11] Add support for MX35 processor Stefano Babic
2011-01-20 9:25 ` Wolfgang Denk
2011-01-20 10:19 ` Stefano Babic
2011-01-20 11:52 ` Wolfgang Denk
2011-01-20 17:49 ` [U-Boot] [PATCH V3 " Stefano Babic
2011-02-01 17:50 ` Stefano Babic
2011-01-20 8:46 ` [U-Boot] [PATCH V2 02/11] serial_mxc: add support for Freescale's i.MX35 processor Stefano Babic
2011-01-20 8:46 ` [U-Boot] [PATCH V2 03/11] mxc_i2c: Add support for the " Stefano Babic
2011-01-21 6:28 ` Heiko Schocher
2011-01-20 8:46 ` [U-Boot] [PATCH V2 04/11] I2C: mxc_i2c: get rid of __REG access Stefano Babic
2011-01-20 9:27 ` Wolfgang Denk
2011-01-20 10:23 ` Stefano Babic
2011-01-20 17:50 ` [U-Boot] [PATCH V3 " Stefano Babic
2011-01-21 6:30 ` Heiko Schocher
2011-01-20 8:46 ` [U-Boot] [PATCH V2 05/11] I2C: mxc_i2c: address failure with mx35 processor Stefano Babic
2011-01-20 9:30 ` Wolfgang Denk
2011-01-20 10:27 ` Stefano Babic
2011-01-20 17:51 ` [U-Boot] [PATCH V3 " Stefano Babic
2011-01-21 6:36 ` Heiko Schocher
2011-01-21 9:08 ` Stefano Babic
2011-01-21 9:21 ` Heiko Schocher
2011-01-20 8:46 ` [U-Boot] [PATCH V2 06/11] Add basic support for Freescale's mc9sdz60 Stefano Babic
2011-01-20 8:46 ` [U-Boot] [PATCH V2 07/11] SPI: mxc_spi: add support for i.MX35 processor Stefano Babic
2011-01-20 8:46 ` [U-Boot] [PATCH V2 08/11] SPI: mxc_spi: fix swapping bug and add missing swapping in unaligned rx case Stefano Babic
2011-01-20 9:32 ` Wolfgang Denk
2011-01-20 10:29 ` Stefano Babic
2011-01-20 11:59 ` Wolfgang Denk
2011-01-20 17:53 ` [U-Boot] [PATCH V3 " Stefano Babic
2011-02-01 17:53 ` Stefano Babic
2011-01-20 8:46 ` [U-Boot] [PATCH V2 09/11] SPI: mxc_spi: add SPI clock calculation and setup to the driver Stefano Babic
2011-02-01 17:58 ` Stefano Babic
2011-01-20 8:46 ` [U-Boot] [PATCH V2 10/11] SPI: mxc_spi: replace fixed offsets with structures Stefano Babic
2011-01-20 9:33 ` Wolfgang Denk
2011-01-20 10:30 ` Stefano Babic
2011-01-20 8:46 ` [U-Boot] [PATCH V2 11/11] Add support for Freescale's mx35pdk board Stefano Babic
2011-01-20 9:41 ` Wolfgang Denk
2011-01-20 10:45 ` Stefano Babic
2011-01-20 12:03 ` Wolfgang Denk
2011-01-20 17:53 ` [U-Boot] [PATCH V3 " Stefano Babic
2011-01-20 18:05 ` [U-Boot] [PATCH V4 " Stefano Babic
2011-02-01 17:51 ` Stefano Babic
2011-02-01 17:51 ` [U-Boot] [PATCH V3 " Stefano Babic
2011-01-20 9:52 ` [U-Boot] Adding support for MX35 Wolfgang Denk
2011-01-20 10:50 ` Stefano Babic [this message]
2011-01-20 12:04 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D381387.50904@denx.de \
--to=sbabic@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.