From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state Date: Mon, 24 Jan 2011 15:08:43 +0100 Message-ID: <4D3D87EB.30508@siemens.com> References: <4D2B6CB5.9050602@codemonkey.ws> <4D2B74D8.4080309@web.de> <4D2B8662.9060909@web.de> <4D2C60FB.7030009@linux.vnet.ibm.com> <4D2D80ED.8030405@redhat.com> <4D2D82EE.20002@siemens.com> <4D35A39A.8000801@siemens.com> <4D35ABF8.9050700@linux.vnet.ibm.com> <4D35B521.3090601@siemens.com> <4D35B6DD.1020005@linux.vnet.ibm.com> <4D3717E7.3010105@linux.vnet.ibm.com> <4D38017D.2020401@siemens.com> <4D3947D2.7070802@redhat.com> <4D39C0B4.3070807@siemens.com> <4D39CDBB.1000709@siemens.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: Gerd Hoffmann , Anthony Liguori , Markus Armbruster , "kvm@vger.kernel.org" , Glauber Costa , Marcelo Tosatti , "qemu-devel@nongnu.org" , Avi Kivity To: Blue Swirl Return-path: Received: from goliath.siemens.de ([192.35.17.28]:16208 "EHLO goliath.siemens.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751529Ab1AXOJH (ORCPT ); Mon, 24 Jan 2011 09:09:07 -0500 In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: On 2011-01-21 19:49, Blue Swirl wrote: >>> I'd add fourth possible class: >>> - device, CPU and machine configuration, like nographic, >>> win2k_install_hack, no_hpet, smp_cpus etc. Maybe also >>> irqchip_in_kernel could fit here, though it obviously depends on a >>> host capability too. >> >> I would count everything that cannot be assigned to a concrete device >> upfront to the dynamic state of a machine, thus class 2. The point is, >> (potentially) every device of that machine requires access to it, just >> like (indirectly, via the KVM core services) to some KVM VM state bits. > > The machine class should not be a catch-all, it would be like > QEMUState or KVMState then. Perhaps each field or variable should be > listed and given more thought. Let's start with what is most urgent: - vmfd: file descriptor required for any KVM request that has VM scope (in-kernel device creation, device state synchronizations, IRQ routing etc.) - irqchip_in_kernel: VM uses in-kernel irqchip acceleration (some devices will have to adjust their behavior depending on this) pit_in_kernel would be analogue to irqchip, but it's also conceptually x86-only (irqchips is only used by x86, but not tied to it) and it's not mandatory for a first round of KVM devices for upstream. Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=43367 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PhN6G-0004yg-Oc for qemu-devel@nongnu.org; Mon, 24 Jan 2011 09:08:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PhN6E-0004S7-CL for qemu-devel@nongnu.org; Mon, 24 Jan 2011 09:08:55 -0500 Received: from goliath.siemens.de ([192.35.17.28]:16111) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PhN6E-0004R9-0I for qemu-devel@nongnu.org; Mon, 24 Jan 2011 09:08:54 -0500 Message-ID: <4D3D87EB.30508@siemens.com> Date: Mon, 24 Jan 2011 15:08:43 +0100 From: Jan Kiszka MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state References: <4D2B6CB5.9050602@codemonkey.ws> <4D2B74D8.4080309@web.de> <4D2B8662.9060909@web.de> <4D2C60FB.7030009@linux.vnet.ibm.com> <4D2D80ED.8030405@redhat.com> <4D2D82EE.20002@siemens.com> <4D35A39A.8000801@siemens.com> <4D35ABF8.9050700@linux.vnet.ibm.com> <4D35B521.3090601@siemens.com> <4D35B6DD.1020005@linux.vnet.ibm.com> <4D3717E7.3010105@linux.vnet.ibm.com> <4D38017D.2020401@siemens.com> <4D3947D2.7070802@redhat.com> <4D39C0B4.3070807@siemens.com> <4D39CDBB.1000709@siemens.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: "kvm@vger.kernel.org" , Glauber Costa , Marcelo Tosatti , Markus Armbruster , "qemu-devel@nongnu.org" , Anthony Liguori , Gerd Hoffmann , Avi Kivity On 2011-01-21 19:49, Blue Swirl wrote: >>> I'd add fourth possible class: >>> - device, CPU and machine configuration, like nographic, >>> win2k_install_hack, no_hpet, smp_cpus etc. Maybe also >>> irqchip_in_kernel could fit here, though it obviously depends on a >>> host capability too. >> >> I would count everything that cannot be assigned to a concrete device >> upfront to the dynamic state of a machine, thus class 2. The point is, >> (potentially) every device of that machine requires access to it, just >> like (indirectly, via the KVM core services) to some KVM VM state bits. > > The machine class should not be a catch-all, it would be like > QEMUState or KVMState then. Perhaps each field or variable should be > listed and given more thought. Let's start with what is most urgent: - vmfd: file descriptor required for any KVM request that has VM scope (in-kernel device creation, device state synchronizations, IRQ routing etc.) - irqchip_in_kernel: VM uses in-kernel irqchip acceleration (some devices will have to adjust their behavior depending on this) pit_in_kernel would be analogue to irqchip, but it's also conceptually x86-only (irqchips is only used by x86, but not tied to it) and it's not mandatory for a first round of KVM devices for upstream. Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux