All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Christie <michaelc@cs.wisc.edu>
To: Hannes Reinecke <hare@suse.de>
Cc: James Bottomley <jbottomley@suse.de>, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] scsi: Erroneous handling of sense status in SCSI EH commands
Date: Mon, 24 Jan 2011 23:18:29 -0600	[thread overview]
Message-ID: <4D3E5D25.9000604@cs.wisc.edu> (raw)
In-Reply-To: <4D3DDE3F.2030902@cs.wisc.edu>

On 01/24/2011 02:17 PM, Mike Christie wrote:
> For example, with your patch if for the
> scsi_send_eh_cmnd/scsi_eh_completed_normally/scsi_check_sense path we
> got 02/04/01 (not ready - becomming ready), scsi_send_eh_cmnd would see
> SOFT_ERROR and fail the scsi eh. And, I am saying don't we want retry
> this like we would if we were going through the normal IO path, so we do
> not offline devices on this type of failure?
>

Just some corrections/clarifications. The device, target and bus reset 
handling are ok, but just host reset handling seems like the problem (at 
least the problem I was hitting I think). We do not call 
__scsi_report_device_reset for host reset handling, but some LLD 
eh_host_reset_handler implementations execute operations that can cause 
us to get something like a UA for the scsi eh TUR. For your patch do you 
also want to call __scsi_report_device_reset for the host reset handling 
for these drivers then?

  reply	other threads:[~2011-01-25  5:18 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-21  8:07 [PATCH] scsi: Erroneous handling of sense status in SCSI EH commands Hannes Reinecke
2011-01-21 20:49 ` Mike Christie
2011-01-24  7:59   ` Hannes Reinecke
2011-01-24 20:17     ` Mike Christie
2011-01-25  5:18       ` Mike Christie [this message]
2011-01-25  5:34         ` Mike Christie
2011-01-25 15:38           ` James Bottomley
2011-01-25 20:19             ` Mike Christie
2011-02-12 16:30 ` James Bottomley
2011-02-14  7:26   ` Hannes Reinecke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D3E5D25.9000604@cs.wisc.edu \
    --to=michaelc@cs.wisc.edu \
    --cc=hare@suse.de \
    --cc=jbottomley@suse.de \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.