From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754144Ab1AYViq (ORCPT ); Tue, 25 Jan 2011 16:38:46 -0500 Received: from mail.hauppauge.com ([167.206.143.4]:1453 "EHLO mail.hauppauge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752919Ab1AYVip (ORCPT ); Tue, 25 Jan 2011 16:38:45 -0500 X-Greylist: delayed 924 seconds by postgrey-1.27 at vger.kernel.org; Tue, 25 Jan 2011 16:38:45 EST Message-ID: <4D3F3F3F.2020308@hauppauge.com> Date: Tue, 25 Jan 2011 16:23:11 -0500 From: Devin Heitmueller User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.13) Gecko/20101208 Thunderbird/3.1.7 MIME-Version: 1.0 To: Peter Huewe CC: Mauro Carvalho Chehab , Sri Deevi , Stephen Rothwell , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org References: <1295987932-19785-1-git-send-email-peterhuewe@gmx.de> In-Reply-To: <1295987932-19785-1-git-send-email-peterhuewe@gmx.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] video/cx231xx: Fix sparse warning: Using plain integer as NULL pointer Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/25/2011 03:38 PM, Peter Huewe wrote: > > This patch fixes the warning "Using plain integer as NULL pointer", > generated by sparse, by replacing the offending 0s with NULL. > > KernelVersion: linus' tree-c723fdab > > Signed-off-by: Peter Huewe > --- > drivers/media/video/cx231xx/cx231xx-417.c | 4 ++-- > drivers/media/video/cx231xx/cx231xx-cards.c | 16 ++++++++-------- > 2 files changed, 10 insertions(+), 10 deletions(-) > > diff --git a/drivers/media/video/cx231xx/cx231xx-417.c > b/drivers/media/video/cx231xx/cx231xx-417.c > index fc9526a..f8f0e59 100644 > --- a/drivers/media/video/cx231xx/cx231xx-417.c > +++ b/drivers/media/video/cx231xx/cx231xx-417.c > @@ -942,13 +942,13 @@ static int cx231xx_load_firmware(struct cx231xx > *dev) > > p_current_fw = vmalloc(1884180 * 4); > p_fw = p_current_fw; > - if (p_current_fw == 0) { > + if (p_current_fw == NULL) { > dprintk(2, "FAIL!!!\n"); > return -1; > } > > p_buffer = vmalloc(4096); > - if (p_buffer == 0) { > + if (p_buffer == NULL) { > dprintk(2, "FAIL!!!\n"); > return -1; > } > diff --git a/drivers/media/video/cx231xx/cx231xx-cards.c > b/drivers/media/video/cx231xx/cx231xx-cards.c > index 588f3e8..5b9b5f4 100644 > --- a/drivers/media/video/cx231xx/cx231xx-cards.c > +++ b/drivers/media/video/cx231xx/cx231xx-cards.c > @@ -357,19 +357,19 @@ struct cx231xx_board cx231xx_boards[] = { > .type = CX231XX_VMUX_TELEVISION, > .vmux = CX231XX_VIN_3_1, > .amux = CX231XX_AMUX_VIDEO, > - .gpio = 0, > + .gpio = NULL, > }, { > .type = CX231XX_VMUX_COMPOSITE1, > .vmux = CX231XX_VIN_2_1, > .amux = CX231XX_AMUX_LINE_IN, > - .gpio = 0, > + .gpio = NULL, > }, { > .type = CX231XX_VMUX_SVIDEO, > .vmux = CX231XX_VIN_1_1 | > (CX231XX_VIN_1_2 << 8) | > CX25840_SVIDEO_ON, > .amux = CX231XX_AMUX_LINE_IN, > - .gpio = 0, > + .gpio = NULL, > } }, > }, > [CX231XX_BOARD_HAUPPAUGE_USBLIVE2] = { > @@ -386,14 +386,14 @@ struct cx231xx_board cx231xx_boards[] = { > .type = CX231XX_VMUX_COMPOSITE1, > .vmux = CX231XX_VIN_2_1, > .amux = CX231XX_AMUX_LINE_IN, > - .gpio = 0, > + .gpio = NULL, > }, { > .type = CX231XX_VMUX_SVIDEO, > .vmux = CX231XX_VIN_1_1 | > (CX231XX_VIN_1_2 << 8) | > CX25840_SVIDEO_ON, > .amux = CX231XX_AMUX_LINE_IN, > - .gpio = 0, > + .gpio = NULL, > } }, > }, > [CX231XX_BOARD_PV_PLAYTV_USB_HYBRID] = { > @@ -420,19 +420,19 @@ struct cx231xx_board cx231xx_boards[] = { > .type = CX231XX_VMUX_TELEVISION, > .vmux = CX231XX_VIN_3_1, > .amux = CX231XX_AMUX_VIDEO, > - .gpio = 0, > + .gpio = NULL, > }, { > .type = CX231XX_VMUX_COMPOSITE1, > .vmux = CX231XX_VIN_2_1, > .amux = CX231XX_AMUX_LINE_IN, > - .gpio = 0, > + .gpio = NULL, > }, { > .type = CX231XX_VMUX_SVIDEO, > .vmux = CX231XX_VIN_1_1 | > (CX231XX_VIN_1_2 << 8) | > CX25840_SVIDEO_ON, > .amux = CX231XX_AMUX_LINE_IN, > - .gpio = 0, > + .gpio = NULL, > } }, > }, > }; > -- > 1.7.2.2 > Reviewed-by: Devin Heitmueller -- Devin Heitmueller Senior Software Engineer Hauppauge Computer Works From mboxrd@z Thu Jan 1 00:00:00 1970 From: Devin Heitmueller Date: Tue, 25 Jan 2011 21:23:11 +0000 Subject: Re: [PATCH] video/cx231xx: Fix sparse warning: Using plain integer as NULL pointer Message-Id: <4D3F3F3F.2020308@hauppauge.com> List-Id: References: <1295987932-19785-1-git-send-email-peterhuewe@gmx.de> In-Reply-To: <1295987932-19785-1-git-send-email-peterhuewe@gmx.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Peter Huewe Cc: Mauro Carvalho Chehab , Sri Deevi , Stephen Rothwell , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org On 01/25/2011 03:38 PM, Peter Huewe wrote: > > This patch fixes the warning "Using plain integer as NULL pointer", > generated by sparse, by replacing the offending 0s with NULL. > > KernelVersion: linus' tree-c723fdab > > Signed-off-by: Peter Huewe > --- > drivers/media/video/cx231xx/cx231xx-417.c | 4 ++-- > drivers/media/video/cx231xx/cx231xx-cards.c | 16 ++++++++-------- > 2 files changed, 10 insertions(+), 10 deletions(-) > > diff --git a/drivers/media/video/cx231xx/cx231xx-417.c > b/drivers/media/video/cx231xx/cx231xx-417.c > index fc9526a..f8f0e59 100644 > --- a/drivers/media/video/cx231xx/cx231xx-417.c > +++ b/drivers/media/video/cx231xx/cx231xx-417.c > @@ -942,13 +942,13 @@ static int cx231xx_load_firmware(struct cx231xx > *dev) > > p_current_fw = vmalloc(1884180 * 4); > p_fw = p_current_fw; > - if (p_current_fw = 0) { > + if (p_current_fw = NULL) { > dprintk(2, "FAIL!!!\n"); > return -1; > } > > p_buffer = vmalloc(4096); > - if (p_buffer = 0) { > + if (p_buffer = NULL) { > dprintk(2, "FAIL!!!\n"); > return -1; > } > diff --git a/drivers/media/video/cx231xx/cx231xx-cards.c > b/drivers/media/video/cx231xx/cx231xx-cards.c > index 588f3e8..5b9b5f4 100644 > --- a/drivers/media/video/cx231xx/cx231xx-cards.c > +++ b/drivers/media/video/cx231xx/cx231xx-cards.c > @@ -357,19 +357,19 @@ struct cx231xx_board cx231xx_boards[] = { > .type = CX231XX_VMUX_TELEVISION, > .vmux = CX231XX_VIN_3_1, > .amux = CX231XX_AMUX_VIDEO, > - .gpio = 0, > + .gpio = NULL, > }, { > .type = CX231XX_VMUX_COMPOSITE1, > .vmux = CX231XX_VIN_2_1, > .amux = CX231XX_AMUX_LINE_IN, > - .gpio = 0, > + .gpio = NULL, > }, { > .type = CX231XX_VMUX_SVIDEO, > .vmux = CX231XX_VIN_1_1 | > (CX231XX_VIN_1_2 << 8) | > CX25840_SVIDEO_ON, > .amux = CX231XX_AMUX_LINE_IN, > - .gpio = 0, > + .gpio = NULL, > } }, > }, > [CX231XX_BOARD_HAUPPAUGE_USBLIVE2] = { > @@ -386,14 +386,14 @@ struct cx231xx_board cx231xx_boards[] = { > .type = CX231XX_VMUX_COMPOSITE1, > .vmux = CX231XX_VIN_2_1, > .amux = CX231XX_AMUX_LINE_IN, > - .gpio = 0, > + .gpio = NULL, > }, { > .type = CX231XX_VMUX_SVIDEO, > .vmux = CX231XX_VIN_1_1 | > (CX231XX_VIN_1_2 << 8) | > CX25840_SVIDEO_ON, > .amux = CX231XX_AMUX_LINE_IN, > - .gpio = 0, > + .gpio = NULL, > } }, > }, > [CX231XX_BOARD_PV_PLAYTV_USB_HYBRID] = { > @@ -420,19 +420,19 @@ struct cx231xx_board cx231xx_boards[] = { > .type = CX231XX_VMUX_TELEVISION, > .vmux = CX231XX_VIN_3_1, > .amux = CX231XX_AMUX_VIDEO, > - .gpio = 0, > + .gpio = NULL, > }, { > .type = CX231XX_VMUX_COMPOSITE1, > .vmux = CX231XX_VIN_2_1, > .amux = CX231XX_AMUX_LINE_IN, > - .gpio = 0, > + .gpio = NULL, > }, { > .type = CX231XX_VMUX_SVIDEO, > .vmux = CX231XX_VIN_1_1 | > (CX231XX_VIN_1_2 << 8) | > CX25840_SVIDEO_ON, > .amux = CX231XX_AMUX_LINE_IN, > - .gpio = 0, > + .gpio = NULL, > } }, > }, > }; > -- > 1.7.2.2 > Reviewed-by: Devin Heitmueller -- Devin Heitmueller Senior Software Engineer Hauppauge Computer Works