All of
 help / color / mirror / Atom feed
From: Kevin Wolf <>
To: Christoph Hellwig <>
Subject: Re: [Qemu-devel] [PATCH 0/3 v3] allow online resizing of block devices
Date: Wed, 26 Jan 2011 11:32:08 +0100	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

Am 24.01.2011 13:32, schrieb Christoph Hellwig:
> This patchset adds support for online resizing of block devices.
> The first patch adds a new resize monitor command which call into
> the existing image resize code.  This is the meat of the series
> and probably needs quite a bit of review and help as I'm not sure
> about how to implement the error handling for monitor commands
> correctly.  Am I really supposed to add a new QERR_ definition
> for each possible error?  And if yes how am I supposed to define
> them?  The macros for them aren't exactly self-explaining.
> The second patch adds a way to tell drivers about a resize, and the
> third one adds a guest notification for config changes to virtio-blk
> which allows the guest to pick it up without a rescan.  I've just sent
> the corresponding Linux guest driver patch to Rusty.
> Changes from version 2 to version 3:
>  - add missing braces
>  - use device as the argument name for the device string
>  - also rename the HMP version of the command to block_resize
> Changes from version 1 to version 2:
>  - also add a QMP command (block_resize)
>  - use the o format for the size in the monitor command
>  - fix typos
>  - use QERR_UNDEFINED_ERROR for errors instead of unstructured strings
>  - remove the CDROM hint check
>  - add a reason argument to the change callback
> ---end quoted text---

Thanks, applied all to the block branch.


  parent reply	other threads:[~2011-01-26 10:30 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-24 12:32 [Qemu-devel] [PATCH 0/3 v3] allow online resizing of block devices Christoph Hellwig
2011-01-24 12:32 ` [Qemu-devel] [PATCH 1/3] block: add block_resize monitor command Christoph Hellwig
2011-01-24 17:44   ` Marcelo Tosatti
2011-01-25 12:01     ` Kevin Wolf
2011-01-25 18:05       ` Christoph Hellwig
2011-01-26 11:56         ` Marcelo Tosatti
2011-01-24 12:32 ` [Qemu-devel] [PATCH 2/3] block: tell drivers about an image resize Christoph Hellwig
2011-01-24 12:32 ` [Qemu-devel] [PATCH 3/3] virtio-blk: tell the guest about size changes Christoph Hellwig
2011-01-26 10:32 ` Kevin Wolf [this message]
2011-01-26 10:49 ` [Qemu-devel] [PATCH 0/3 v3] allow online resizing of block devices Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.