All of
 help / color / mirror / Atom feed
From: "Matthias Weißer" <>
Subject: [U-Boot] [PATCH V2] arm: Use optimized memcpy and memset from linux
Date: Wed, 26 Jan 2011 13:50:53 +0100	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

Am 26.01.2011 13:07, schrieb Albert ARIBAUD:
>> ---
> IIRC, the '---' line separates patch commit message (above) from
> freeform comments and history (below). Here, at least the version
> history should move below the '---' line.

Wolfgang asked me that I add the numbers to the commit message. For the 
changelog I will investigate the git commands on how to do that best 
without manually editing the patch file before git send-email them.

>> + If these options are used a optimized version of memcpy/memset will
>> + be used if available. These functions may be faster under some
>> + conditions but may increase the binary size.
>> +
> The name of the options is not self-explaining to me. If the difference
> is "generic vs arch-optimal", then maybe CONFIG_USE_ARCH_OPTIMAL_MEMxxx
> would be a better name?

Wolfgang didn't object on these names. If we use the OPTIMAL form it is 
still not clear what optimal mean. There may be a size optimized version 
and a speed optimized version. So we would need 
CONFIG_USE_ARCH_SPEED_OPTIMAL_MEMxxx which I personally dislike a lot as 
it is quite long. I also think that if there is an architecture specific 
function that it should be clear that this is optimal in some way.

Thanks for review


  reply	other threads:[~2011-01-26 12:50 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-24 15:56 [U-Boot] [PATCH] arm: Use optimized memcpy and memset from linux Matthias Weisser
2011-01-24 16:13 ` Wolfgang Denk
2011-01-24 19:24   ` Matthias Weißer
2011-01-24 20:07     ` Wolfgang Denk
2011-01-25 10:55       ` Matthias Weißer
2011-01-25 20:05         ` Wolfgang Denk
2011-01-26 10:45 ` [U-Boot] [PATCH V2] " Matthias Weisser
2011-01-26 12:07   ` Albert ARIBAUD
2011-01-26 12:50     ` Matthias Weißer [this message]
2011-01-26 13:07       ` Wolfgang Denk
2011-01-27 18:39         ` Albert ARIBAUD
2011-02-20 19:35   ` Alexander Holler
2011-03-03  7:07   ` Albert ARIBAUD
2011-03-11  7:36 ` [U-Boot] [PATCH V3] " Matthias Weisser
2011-03-24 14:34   ` Albert ARIBAUD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.