From: Jan Kiszka <jan.kiszka@siemens.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Avi Kivity <avi@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] Re: [PATCH] kvm: Prevent dynticks race condition for !CONFIG_IOTHREAD
Date: Wed, 26 Jan 2011 15:25:26 +0100 [thread overview]
Message-ID: <4D402ED6.2020300@siemens.com> (raw)
In-Reply-To: <AANLkTi=Nr9V1RFUAj03d7O01HMNT=uEC7BnGrVY25VxV@mail.gmail.com>
On 2011-01-26 15:01, Stefan Hajnoczi wrote:
> On Wed, Jan 26, 2011 at 1:56 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
>> Looks like this should also include SIGIO in case hpet is selected as
>> host timer.
>
> Yeah that can't hurt although since hpet is periodic we don't risk
> forgetting to rearm the timer.
>
> Can you explain the signalfd idea a little more? I'm not sure that
> model would work for !CONFIG_IOTHREAD. Maybe if QEMU itself uses
> signalfd but KVM sigmask is used to unblock the signals during guest
> code execution (and a solution for TCG too).
Will push a version I would like you to test as well in a few minutes.
This is already the concept: As under IOTHREAD, we will block SIGIO and
SIGALARM the whole time - except during KVM_RUN - and catch those
signals via qemu_signalfd in the main select loop. Of course, this
includes setting up the kvm signal mask properly as well (was already
part of my previously posted series for other reasons).
Jan
--
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux
prev parent reply other threads:[~2011-01-26 14:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-26 9:39 [Qemu-devel] [PATCH] kvm: Prevent dynticks race condition for !CONFIG_IOTHREAD Stefan Hajnoczi
2011-01-26 13:12 ` [Qemu-devel] " Jan Kiszka
2011-01-26 13:56 ` Jan Kiszka
2011-01-26 14:01 ` Stefan Hajnoczi
2011-01-26 14:25 ` Jan Kiszka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D402ED6.2020300@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=avi@redhat.com \
--cc=mtosatti@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.