* netfilter: xt_connlimit: pick right dstaddr in NAT scenario
@ 2011-01-26 12:07 Jan Engelhardt
2011-01-26 15:29 ` Patrick McHardy
0 siblings, 1 reply; 2+ messages in thread
From: Jan Engelhardt @ 2011-01-26 12:07 UTC (permalink / raw)
To: Patrick McHardy; +Cc: Netfilter Developer Mailing List, Jan Rovner
The following changes since commit 4b3fd57138c969dd940651fadf90db627254edbf:
IPVS: Change sock_create_kernel() to __sock_create() (2011-01-22 13:48:01 +1100)
are available in the git repository at:
git://dev.medozas.de/linux connlimit
Jan Engelhardt (1):
netfilter: xt_connlimit: pick right dstaddr in NAT scenario
net/netfilter/xt_connlimit.c | 12 ++++++++----
1 files changed, 8 insertions(+), 4 deletions(-)
===
parent 4b3fd57138c969dd940651fadf90db627254edbf (v2.6.38-rc1-151-g4b3fd57)
commit ad86e1f27a9a97a9e50810b10bca678407b1d6fd
Author: Jan Engelhardt <jengelh@medozas.de>
Date: Wed Jan 26 11:50:03 2011 +0100
netfilter: xt_connlimit: pick right dstaddr in NAT scenario
xt_connlimit normally records the "original" tuples in a hashlist
(such as "1.2.3.4 -> 5.6.7.8"), and looks in this list for iph->daddr
when counting.
When the user however uses DNAT in PREROUTING, looking for
iph->daddr -- which is now 192.168.9.10 -- will not match. Thus in
daddr mode, we need to record the reverse direction tuple
("192.168.9.10 -> 1.2.3.4") instead. In the reverse tuple, the dst
addr is on the src side, which is convenient, as count_them still uses
&conn->tuple.src.u3.
Signed-off-by: Jan Engelhardt <jengelh@medozas.de>
---
net/netfilter/xt_connlimit.c | 12 ++++++++----
1 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/net/netfilter/xt_connlimit.c b/net/netfilter/xt_connlimit.c
index 7fd3fd5..e029c48 100644
--- a/net/netfilter/xt_connlimit.c
+++ b/net/netfilter/xt_connlimit.c
@@ -185,11 +185,15 @@ connlimit_mt(const struct sk_buff *skb, struct xt_action_param *par)
int connections;
ct = nf_ct_get(skb, &ctinfo);
- if (ct != NULL)
- tuple_ptr = &ct->tuplehash[0].tuple;
- else if (!nf_ct_get_tuplepr(skb, skb_network_offset(skb),
- par->family, &tuple))
+ if (ct != NULL) {
+ if (info->flags & XT_CONNLIMIT_DADDR)
+ tuple_ptr = &ct->tuplehash[IP_CT_DIR_REPLY].tuple;
+ else
+ tuple_ptr = &ct->tuplehash[IP_CT_DIR_ORIGINAL].tuple;
+ } else if (!nf_ct_get_tuplepr(skb, skb_network_offset(skb),
+ par->family, &tuple)) {
goto hotdrop;
+ }
if (par->family == NFPROTO_IPV6) {
const struct ipv6hdr *iph = ipv6_hdr(skb);
--
# Created with git-export-patch
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: netfilter: xt_connlimit: pick right dstaddr in NAT scenario
2011-01-26 12:07 netfilter: xt_connlimit: pick right dstaddr in NAT scenario Jan Engelhardt
@ 2011-01-26 15:29 ` Patrick McHardy
0 siblings, 0 replies; 2+ messages in thread
From: Patrick McHardy @ 2011-01-26 15:29 UTC (permalink / raw)
To: Jan Engelhardt; +Cc: Netfilter Developer Mailing List, Jan Rovner
On 26.01.2011 13:07, Jan Engelhardt wrote:
>
>
> The following changes since commit 4b3fd57138c969dd940651fadf90db627254edbf:
>
> IPVS: Change sock_create_kernel() to __sock_create() (2011-01-22 13:48:01 +1100)
>
> are available in the git repository at:
> git://dev.medozas.de/linux connlimit
>
> Jan Engelhardt (1):
> netfilter: xt_connlimit: pick right dstaddr in NAT scenario
>
> net/netfilter/xt_connlimit.c | 12 ++++++++----
> 1 files changed, 8 insertions(+), 4 deletions(-)
>
> ===
>
> parent 4b3fd57138c969dd940651fadf90db627254edbf (v2.6.38-rc1-151-g4b3fd57)
> commit ad86e1f27a9a97a9e50810b10bca678407b1d6fd
> Author: Jan Engelhardt <jengelh@medozas.de>
> Date: Wed Jan 26 11:50:03 2011 +0100
>
> netfilter: xt_connlimit: pick right dstaddr in NAT scenario
>
> xt_connlimit normally records the "original" tuples in a hashlist
> (such as "1.2.3.4 -> 5.6.7.8"), and looks in this list for iph->daddr
> when counting.
>
> When the user however uses DNAT in PREROUTING, looking for
> iph->daddr -- which is now 192.168.9.10 -- will not match. Thus in
> daddr mode, we need to record the reverse direction tuple
> ("192.168.9.10 -> 1.2.3.4") instead. In the reverse tuple, the dst
> addr is on the src side, which is convenient, as count_them still uses
> &conn->tuple.src.u3.
>
Pulled, thanks Jan.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-01-26 15:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-01-26 12:07 netfilter: xt_connlimit: pick right dstaddr in NAT scenario Jan Engelhardt
2011-01-26 15:29 ` Patrick McHardy
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.