From: Reinhard Meyer <u-boot@emk-elektronik.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 2/3] Add support for Bluewater Systems Snapper 9260 and 9G20 modules
Date: Thu, 27 Jan 2011 07:13:21 +0100 [thread overview]
Message-ID: <4D410D01.4070401@emk-elektronik.de> (raw)
In-Reply-To: <4D40B8EE.50108@bluewatersys.com>
Dear Ryan Mallon,
> Did you have any additional changes you want made for the
> Snapper9260/9G20 patches other than adding a MAINTAINERS entry and
> rolling the boards.cfg change into a single patch?
Yes, the following things should be changed:
1. sort the boards.cfg entry to the right place.
See top of boards.cfg for the rules.
bluewater would be between atmel and emk ;)
2. #define SOMETHING 1. The "1" is depreciated if it serves no numeric
meaning. Remove them in your board config.
(Make sure the white space goes as well)
3. SZ_* macros are depreciated. Use numeric values. (256 << 20) is
preferred to denote 256MiB.
Sorry I had no time to look deeper into details, but it looked good otherwise.
Can you confirm that the code builds and runs after the changes?
I can't verify the "runs" part...
Best Regards,
Reinhard
next prev parent reply other threads:[~2011-01-27 6:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-25 22:52 [U-Boot] [PATCH v2 0/3] Add Bluewater Systems Snapper 9260/9G20 module support Ryan Mallon
2011-01-25 22:52 ` [U-Boot] [PATCH v2 1/3] Fix at91 includes in soft_i2c driver Ryan Mallon
2011-01-25 22:52 ` [U-Boot] [PATCH v2 2/3] Add support for Bluewater Systems Snapper 9260 and 9G20 modules Ryan Mallon
2011-01-25 22:52 ` [U-Boot] [PATCH v2 3/3] Add Bluewater Systems Snapper 9260 and 9G20 modules to top-level boards.cfg Ryan Mallon
2011-01-26 7:22 ` Wolfgang Denk
2011-01-26 7:22 ` [U-Boot] [PATCH v2 2/3] Add support for Bluewater Systems Snapper 9260 and 9G20 modules Wolfgang Denk
2011-01-26 7:40 ` Reinhard Meyer
2011-01-27 0:14 ` Ryan Mallon
2011-01-27 6:13 ` Reinhard Meyer [this message]
2011-01-26 7:19 ` [U-Boot] [PATCH v2 1/3] Fix at91 includes in soft_i2c driver Wolfgang Denk
2011-01-26 7:30 ` Heiko Schocher
2011-01-26 7:37 ` Reinhard Meyer
2011-01-26 7:49 ` Heiko Schocher
2011-01-26 8:18 ` Reinhard Meyer
2011-01-26 18:27 ` Andreas Bießmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D410D01.4070401@emk-elektronik.de \
--to=u-boot@emk-elektronik.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.