From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=33089 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PiTq2-0000p5-KJ
	for qemu-devel@nongnu.org; Thu, 27 Jan 2011 10:32:48 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1PiTq0-0005Qs-Vp
	for qemu-devel@nongnu.org; Thu, 27 Jan 2011 10:32:46 -0500
Received: from mx1.redhat.com ([209.132.183.28]:55062)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1PiTq0-0005QY-Lr
	for qemu-devel@nongnu.org; Thu, 27 Jan 2011 10:32:44 -0500
Message-ID: <4D419018.8080901@redhat.com>
Date: Thu, 27 Jan 2011 16:32:40 +0100
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <4D416F07.6060604@redhat.com>
	<20110127151211.GB19334@playa.tlv.redhat.com>
In-Reply-To: <20110127151211.GB19334@playa.tlv.redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [Spice-devel] paravirtual mouse/tablet, v5
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, Peter Hutterer <peter.hutterer@who-t.net>, spice-devel <spice-devel@lists.freedesktop.org>

   Hi,

>> typedef struct qemu_pvmouse_ack {
>>      uint32_t features; /* qemu_pvtable_features */
>
> Why does this comment say "qemu_pvtable_features" and the one above
> says "qemu_pvmouse_features"?

Not intentional, will fix.  Leftover because it is misspelled (t in 
table*t* missing), so the search+replace didn't catch it.

>> };
>>
>>
>> enum qemu_pvmouse_axis_type {
>>      /* absolute */
>>      QEMU_PVMOUSE_AXIS_POS_X = 1,
>>      QEMU_PVMOUSE_AXIS_POS_Y,
>>      QEMU_PVMOUSE_AXIS_PRESSURE,
>>
>
> So is the concensus to not treat 3d mice as core protocol?
> just a AXIS_POS_Z and AXIS_REL_Z I think would be simple to
> add. Running cad apps in a vm seems possible.

That list isn't meant to be complete, I'll happily take suggestions for 
axises we should add here.  *_Z for a 3d mouse certainly is reasonable.

> What's the outcome of the discussion with Peter? wasn't there
> a suggestion to send information from the host to the guest about
> monitor configuration, so guest can do inverse to send correct
> coordinates to host?

Yep.  I think that isn't something for the pvmouse but for vdagent 
though.  In the simplest case make VDAgentMonitorsConfig bidirectional, 
so the guest can send feedback to the spice client and inform how the 
actual configuration looks like.

cheers,
   Gerd