All of lore.kernel.org
 help / color / mirror / Atom feed
From: Albert ARIBAUD <albert.aribaud@free.fr>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v5 1/1] imximage: Add MX53 boot image support
Date: Thu, 27 Jan 2011 19:24:56 +0100	[thread overview]
Message-ID: <4D41B878.40307@free.fr> (raw)
In-Reply-To: <AANLkTincivXtQdCAqbs4hMKc6iK8wCEdGSNYEB+aQ=5A@mail.gmail.com>

Le 25/01/2011 08:56, Jason Liu a ?crit :
> Hi, Wolfgang,
>
> 2011/1/20 Jason Liu<r64343@freescale.com>:
>> This patch add the MX53 boot image support.
>>
>> This patch has been tested on Freescale MX53EVK board
>> and MX51EVK board.
>>
>> Signed-off-by: Jason Liu<r64343@freescale.com>
>>
>> ---
>> Changes for v2:
>> - Address the following comments from Stefano,
>>   - Get rid of  #ifdef in the imximage.h and .c file and use
>>     the runtime check for imximage version
>>   - Document the IMXIMAGE_VERSION definiton in doc/README.imximage
>>   - Move mx53evk/config.mk and mx53evk/imximage.cfg to MX53EVK board
>>     support patch.
>>
>> Changes for v3:
>> - Address the following comments from Stefano,
>>   - Not change the mx51evk file. The code should take VERSION=1 as default,
>>    and we do not need to change the actual boards.
>>   - add a note in the documentation and raise an error in code if the
>>    VERSION command is read after any other suitable commands.
>>   - Change command IMXIMAGE_VERSION simply to IMAGE_VERSION
>>   - Need recognize the version directly from its structure and not storing the
>>    version into the header when do header verify and print.
>>   - Use function pointer to simpliy the code when the version of header is recognized
>> Changes for v4:
>> - Address the following comments from Wolfgang,
>>   - Keep the imximage_cmds table sorted,
>>   - Add braces for (expx)&&  (expy) gloably,
>>   - Return failure to upper call if met errors for function
>>   - Add comments for function set_dcd_rst_v1 alike,
>>   - Re-orgnize code to avoid deep nesting,
>> Changes for v5:
>>   - Remove the blank line before the only one line statement and
>>   not using braces for the one line statment for the sake of the
>>   same coding style of this file. For example,
>>   if (!exp)
>>         return ret;
>> ---
>>   doc/README.imximage |   12 +-
>>   tools/imximage.c    |  525 +++++++++++++++++++++++++++++++++++++--------------
>>   tools/imximage.h    |  110 +++++++++--
>>   3 files changed, 487 insertions(+), 160 deletions(-)
>>
>
> Any feedback about this patch?

I think Stefano should be added in Cc: as IMX custodian.

Amicalement,
-- 
Albert.

  reply	other threads:[~2011-01-27 18:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-19 19:40 [U-Boot] [PATCH v5 1/1] imximage: Add MX53 boot image support Jason Liu
2011-01-25  7:56 ` Jason Liu
2011-01-27 18:24   ` Albert ARIBAUD [this message]
2011-01-27 18:51     ` Stefano Babic
2011-02-01 17:40 ` Stefano Babic
2012-02-13 14:10 ` [U-Boot] imximage: Create i.MX6 NOR flash images (was: [PATCH v5 1/1] imximage: Add MX53 boot image support) Dirk Behme

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D41B878.40307@free.fr \
    --to=albert.aribaud@free.fr \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.