From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=38706 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PiXUA-0002BC-9n
	for qemu-devel@nongnu.org; Thu, 27 Jan 2011 14:26:28 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1PiXU1-0007x4-Nk
	for qemu-devel@nongnu.org; Thu, 27 Jan 2011 14:26:18 -0500
Received: from mx1.redhat.com ([209.132.183.28]:33462)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1PiXU1-0007wo-Bf
	for qemu-devel@nongnu.org; Thu, 27 Jan 2011 14:26:17 -0500
Message-ID: <4D41C6CA.2000404@redhat.com>
Date: Thu, 27 Jan 2011 20:26:02 +0100
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] Re: Commit 622b520f changed -drive if=scsi, index=N,
	intentional?
References: <m3oc72eed1.fsf@blackfin.pond.sub.org>
	<4D416342.6080001@redhat.com>
In-Reply-To: <4D416342.6080001@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org, Hannes Reinecke <hare@suse.de>, Markus Armbruster <armbru@redhat.com>, Christoph Hellwig <hch@lst.de>

   Hi,

>           } else if (!strcmp(buf, "scsi")) {
>              type = IF_SCSI;
> -            max_devs = MAX_SCSI_DEVS;
> +            max_devs = 7;

> That's very obviously not much more than a hack, but I don't think
> blockdev.c can get the real number easily (please prove me wrong). With
> this hack, we would get the old behaviour for -drive (which doesn't use
> any other controller anyway) and you can still use -device to attach
> more devices to a non-lsi bus.

Looks sensible to me.  scsi controllers with more than 7 devs (megasas 
and whatever else might be coming, virtio?) can't be added via if=scsi 
legacy syntax and must use -blockdev and -device anyway.

We probably want add a comment explaining this though.

cheers,
   Gerd