From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=48590 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Pik5R-0004hv-S5 for qemu-devel@nongnu.org; Fri, 28 Jan 2011 03:53:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Pik54-0006jS-Fg for qemu-devel@nongnu.org; Fri, 28 Jan 2011 03:53:45 -0500 Received: from mail-iw0-f173.google.com ([209.85.214.173]:65375) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Pik54-0006jL-BR for qemu-devel@nongnu.org; Fri, 28 Jan 2011 03:53:22 -0500 Received: by iwn40 with SMTP id 40so2981890iwn.4 for ; Fri, 28 Jan 2011 00:53:21 -0800 (PST) Message-ID: <4D41E6C2.8020107@codemonkey.ws> Date: Thu, 27 Jan 2011 15:42:26 -0600 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 2/7] ccid: add passthru card device References: <1294735359-4009-1-git-send-email-alevy@redhat.com> <1294735359-4009-3-git-send-email-alevy@redhat.com> <4D3EDB7C.3050604@codemonkey.ws> <20110127211323.GA27130@playa.redhat.com> In-Reply-To: <20110127211323.GA27130@playa.redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Alon Levy On 01/27/2011 03:13 PM, Alon Levy wrote: >> This is not ipv6 friendly. Two strings would be a better choice. >> > A string for host makes sense, why for port? isn't a 32 bit port enough? > For an protocol, an integer is probably fine. For an API, a string is nice to allow service names too. Regards, Anthony Liguori >> Regards, >> >> Anthony Liguori >> >> >>> + uint16_t port; >>> +} VSCMsgReconnect; >>> + >>> +#endif >>> >>