From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andre Przywara <andre.przywara@amd.com>
Subject: [PATCH] xl: fix xl cpupool-list <poolid>
Date: Fri, 28 Jan 2011 00:34:02 +0100
Message-ID: <4D4200EA.2020708@amd.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="------------000704010504050009030705"
Return-path: <xen-devel-bounces@lists.xensource.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Ian Jackson <Ian.Jackson@eu.citrix.com>, Juergen Gross <juergen.gross@ts.fujitsu.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

--------------000704010504050009030705
Content-Type: text/plain; charset="ISO-8859-1"; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

the help screen of xl cpupool-list promises to allow a CPU pool to
be named on the command line, which will then be listed only.
Probably caused by a "DeMorgan brain twist" this specific CPU pool
is _omitted_ instead. The patch fixes this, so single CPU pools
can be explicitly listed again.

Signed-off-by: Andre Przywara <andre.przywara@amd.com>

Regards,
Andre.

-- 
Andre Przywara
AMD-Operating System Research Center (OSRC), Dresden, Germany


--------------000704010504050009030705
Content-Type: text/plain; name="xl_fix_cpupool_list_poolid.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="xl_fix_cpupool_list_poolid.patch"
Content-Description: xl_fix_cpupool_list_poolid.patch

commit 94738f94d02714624a6aa1a66b3af23cc7941ef3
Author: Andre Przywara <andre.przywara@amd.com>
Date:   Thu Jan 27 23:55:40 2011 +0100

    fix xl cpupool-list <poolid>
    
    The help screen of cpupool-list promises to allow a CPU pool to
    be named on the command line, which will then be listed only.
    Probably caused by a "DeMorgan brain twist" this specific CPU pool
    is _omitted_ instead. The patch fixes this, so single CPU pools
    can be explicitly listed again.
    
    Signed-off-by: Andre Przywara <andre.przywara@amd.com>

diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c
index e0aa93d..6341767 100644
--- a/tools/libxl/xl_cmdimpl.c
+++ b/tools/libxl/xl_cmdimpl.c
@@ -5427,7 +5427,7 @@ int main_cpupoollist(int argc, char **argv)
         printf("CPUs   Sched     Active   Domain count\n");
 
     for (p = 0; p < n_pools; p++) {
-        if (!ret && (!pool || (poolinfo[p].poolid != poolid))) {
+        if (!ret && (!pool || (poolinfo[p].poolid == poolid))) {
             name = libxl_cpupoolid_to_name(&ctx, poolinfo[p].poolid);
             if (!name) {
                 fprintf(stderr, "error getting cpupool info\n");

--------------000704010504050009030705
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

--------------000704010504050009030705--