From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=54398 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PiieO-0000Hr-VG
	for qemu-devel@nongnu.org; Fri, 28 Jan 2011 02:21:46 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1PiieN-0006Yy-MP
	for qemu-devel@nongnu.org; Fri, 28 Jan 2011 02:21:44 -0500
Received: from mail-qy0-f173.google.com ([209.85.216.173]:54044)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1PiieN-0006YU-Gg
	for qemu-devel@nongnu.org; Fri, 28 Jan 2011 02:21:43 -0500
Received: by qyl38 with SMTP id 38so526132qyl.4
	for <qemu-devel@nongnu.org>; Thu, 27 Jan 2011 23:21:42 -0800 (PST)
Message-ID: <4D420FF8.6000300@codemonkey.ws>
Date: Thu, 27 Jan 2011 18:38:16 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PING 0.14] fix crash when a read handler calls
	qemu_set_fd_handler2()
References: <4D412CF0.30706@redhat.com>	<4D419DB6.6000707@codemonkey.ws>	<201101271044.00845.rickv@hobi.com>	<4D41A811.9080004@codemonkey.ws>
	<AANLkTimdvtT8Dap622s7ESRDDvkCLnPivARWqpj4UBOA@mail.gmail.com>
In-Reply-To: <AANLkTimdvtT8Dap622s7ESRDDvkCLnPivARWqpj4UBOA@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>

On 01/27/2011 01:50 PM, Stefan Hajnoczi wrote:
> On Thu, Jan 27, 2011 at 5:14 PM, Anthony Liguori<anthony@codemonkey.ws>  wrote:
>    
>> On 01/27/2011 10:44 AM, Rick Vernam wrote:
>>      
>>>>> Please reply to this message with a subject starting with "[PING 0.14]"
>>>>> and a link to patchwork, gmane, or whatnot; or "[PULL 0.14]" for tree
>>>>> pulls.  Also, I believe all patches meant for stable should also start
>>>>> having "[PATCH 0.14]", too.
>>>>>
>>>>>            
>>> I am not the author of this patch, but it fixed a crash that was bugging
>>> me
>>> consistently.
>>>
>>> http://patchwork.ozlabs.org/patch/62420/
>>>
>>>        
>> Stefan, I thought we're carryign a patch from you that fixes this problem?
>>   Am I mistaken?
>>      
> Yes, that crash was fixed in qemu.git by
> 0290b57bdfec83ca78b6d119ea9847bb17943328 "Delete IOHandlers after
> potentially running them".
>
> To be fair Corentin and Yoshiaki seemed in favor of applying this one
> regardless:
> http://patchwork.ozlabs.org/patch/80335/
>    

Yeah, the logic is bad there though.  The ioh gets freed as soon as that 
condition is over so the assignments to NULL are pointless.

But at any rate, let's just get rid of the whole dang thing and get a 
glib based main loop in as soon as we can.

Regards,

Anthony Liguori

> Stefan
>