From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=58348 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Pionf-0000dX-75
	for qemu-devel@nongnu.org; Fri, 28 Jan 2011 08:55:45 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <chouteau@adacore.com>) id 1Piona-0004ru-Eo
	for qemu-devel@nongnu.org; Fri, 28 Jan 2011 08:55:43 -0500
Received: from mel.act-europe.fr ([194.98.77.210]:40299)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <chouteau@adacore.com>) id 1Piona-0004lQ-7e
	for qemu-devel@nongnu.org; Fri, 28 Jan 2011 08:55:38 -0500
Received: from localhost (localhost [127.0.0.1])
	by filtered-smtp.eu.adacore.com (Postfix) with ESMTP id 4840ACB0345
	for <qemu-devel@nongnu.org>; Fri, 28 Jan 2011 14:55:25 +0100 (CET)
Received: from mel.act-europe.fr ([127.0.0.1])
	by localhost (smtp.eu.adacore.com [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id aO8a0dEVG3Uc for <qemu-devel@nongnu.org>;
	Fri, 28 Jan 2011 14:55:25 +0100 (CET)
Received: from [10.10.1.88] (pompomgalli.act-europe.fr [10.10.1.88])
	(using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
	(No client certificate requested)
	by mel.act-europe.fr (Postfix) with ESMTP id 2A539CB02A0
	for <qemu-devel@nongnu.org>; Fri, 28 Jan 2011 14:55:25 +0100 (CET)
Message-ID: <4D42CAC8.6090905@adacore.com>
Date: Fri, 28 Jan 2011 14:55:20 +0100
From: Fabien Chouteau <chouteau@adacore.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH v4] New trace-event backend: stderr
References: <00f9ac47200684b4a0061dce755af0a280ebd648.1296120144.git.chouteau@adacore.com>
In-Reply-To: <00f9ac47200684b4a0061dce755af0a280ebd648.1296120144.git.chouteau@adacore.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On 01/27/2011 10:24 AM, Fabien Chouteau wrote:
> This backend sends trace events to standard error output during the emulation.
>
> Also add a "--list-backends" option to tracetool, so configure script can
> display the list of available backends.
>
> Signed-off-by: Fabien Chouteau<chouteau@adacore.com>
> ---
>   configure         |    3 +-
>   docs/tracing.txt  |    5 ++++
>   scripts/tracetool |   60 +++++++++++++++++++++++++++++++++++++++++++++++++++-
>   3 files changed, 65 insertions(+), 3 deletions(-)
>
> diff --git a/configure b/configure
> index 210670c..fcc5a71 100755
> --- a/configure
> +++ b/configure
> @@ -907,7 +907,8 @@ echo "  --enable-docs            enable documentation build"
>   echo "  --disable-docs           disable documentation build"
>   echo "  --disable-vhost-net      disable vhost-net acceleration support"
>   echo "  --enable-vhost-net       enable vhost-net acceleration support"
> -echo "  --enable-trace-backend=B Trace backend nop simple ust dtrace"
> +echo "  --enable-trace-backend=B Set trace backend"
> +echo "                           Available backends:" $("$source_path"/scripts/tracetool --list-backends)
>   echo "  --with-trace-file=NAME   Full PATH,NAME of file to store traces"
>   echo "                           Default:trace-<pid>"
>   echo "  --disable-spice          disable spice"
> diff --git a/docs/tracing.txt b/docs/tracing.txt
> index 963c504..21183f9 100644
> --- a/docs/tracing.txt
> +++ b/docs/tracing.txt
> @@ -133,6 +133,11 @@ source tree.  It may not be as powerful as platform-specific or third-party
>   trace backends but it is portable.  This is the recommended trace backend
>   unless you have specific needs for more advanced backends.
>
> +=== Stderr ===
> +
> +The "stderr" backend sends trace events directly to standard error output
> +during emulation.
> +
>   ==== Monitor commands ====
>
>   * info trace
> diff --git a/scripts/tracetool b/scripts/tracetool
> index fce491c..e046683 100755
> --- a/scripts/tracetool
> +++ b/scripts/tracetool
> @@ -13,12 +13,13 @@ set -f
>   usage()
>   {
>       cat>&2<<EOF
> -usage: $0 [--nop | --simple | --ust] [-h | -c]
> +usage: $0 [--nop | --simple | --stderr | --ust | --dtrace] [-h | -c]
>   Generate tracing code for a file on stdin.
>
>   Backends:
>     --nop     Tracing disabled
>     --simple  Simple built-in backend
> +  --stderr  Stderr built-in backend
>     --ust     LTTng User Space Tracing backend
>     --dtrace  DTrace/SystemTAP backend
>
> @@ -236,6 +237,56 @@ linetoc_end_simple()
>   EOF
>   }
>
> +#STDERR
> +linetoh_begin_stderr()
> +{
> +    cat<<EOF
> +#include<stdio.h>
> +EOF
> +}
> +
> +linetoh_stderr()
> +{
> +    local name args argnames argc fmt
> +    name=$(get_name "$1")
> +    args=$(get_args "$1")
> +    argnames=$(get_argnames "$1" ",")
> +    argc=$(get_argc "$1")
> +    fmt=$(get_fmt "$1")
> +
> +    if [ "$argc" -gt 0 ]; then
> +        argnames=", $argnames"
> +    fi
> +
> +    cat<<EOF
> +static inline void trace_$name($args)
> +{
> +    fprintf(stderr, "$name $fmt\n" $argnames);
> +}
> +EOF
> +}
> +
> +linetoh_end_stderr()
> +{
> +return
> +}
> +
> +linetoc_begin_stderr()
> +{
> +return
> +}
> +
> +linetoc_stderr()
> +{
> +return
> +}
> +
> +linetoc_end_stderr()
> +{
> +return
> +}
> +#END OF STDERR
> +
>   # Clean up after UST headers which pollute the namespace
>   ust_clean_namespace() {
>       cat<<EOF
> @@ -546,7 +597,7 @@ targetarch=
>   until [ -z "$1" ]
>   do
>     case "$1" in
> -    "--nop" | "--simple" | "--ust" | "--dtrace") backend="${1#--}" ;;
> +    "--nop" | "--simple" | "--stderr" | "--ust" | "--dtrace") backend="${1#--}" ;;
>
>       "--binary") shift ; binary="$1" ;;
>       "--target-arch") shift ; targetarch="$1" ;;
> @@ -557,6 +608,11 @@ do
>
>       "--check-backend") exit 0 ;; # used by ./configure to test for backend
>
> +    "--list-backends") # used by ./configure to list available backends
> +          echo "nop simple stderr ust dtrace"
> +          exit 0
> +          ;;
> +
>       *)
>         usage;;
>     esac

Any comment for this version?

-- 
Fabien Chouteau