From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [Qemu-devel] Re: [PATCH 19/19] migration: add a parser to accept FT migration incoming mode. Date: Fri, 28 Jan 2011 16:10:22 +0100 Message-ID: <4D42DC5E.8060203@redhat.com> References: <1296199312-26334-1-git-send-email-tamura.yoshiaki@lab.ntt.co.jp> <1296199312-26334-20-git-send-email-tamura.yoshiaki@lab.ntt.co.jp> <4D42BD7D.8020004@redhat.com> <4D42D601.9010905@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kwolf@redhat.com, aliguori@us.ibm.com, dlaor@redhat.com, ananth@in.ibm.com, kvm@vger.kernel.org, mst@redhat.com, mtosatti@redhat.com, qemu-devel@nongnu.org, vatsa@linux.vnet.ibm.com, blauwirbel@gmail.com, ohmura.kei@lab.ntt.co.jp, avi@redhat.com, psuriset@linux.vnet.ibm.com, stefanha@linux.vnet.ibm.com To: Yoshiaki Tamura Return-path: Received: from mx1.redhat.com ([209.132.183.28]:64320 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754924Ab1A1PKj (ORCPT ); Fri, 28 Jan 2011 10:10:39 -0500 In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: On 01/28/2011 04:05 PM, Yoshiaki Tamura wrote: > Having a scheme like "kemari:tcp:host:port" looks quite > challenging to me. We can of course add some quick hacks for it, > but adding a nice layered architecture should be more > appropriate. Similar to protocols and formats in block layer? > At the same time, I want to avoid anything over engineered. I was simply thinking of if (strstart (uri, "kemari:", &p)) { ft_mode = FT_INIT; uri = p; } :) I think the same could be done for outgoing migration instead of -k actually. Paolo From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=40496 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PiqX3-0002ho-GL for qemu-devel@nongnu.org; Fri, 28 Jan 2011 10:46:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PiqX1-0008Kw-G6 for qemu-devel@nongnu.org; Fri, 28 Jan 2011 10:46:41 -0500 Received: from mx1.redhat.com ([209.132.183.28]:31297) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PiqX1-0008Ki-5F for qemu-devel@nongnu.org; Fri, 28 Jan 2011 10:46:39 -0500 Message-ID: <4D42DC5E.8060203@redhat.com> Date: Fri, 28 Jan 2011 16:10:22 +0100 From: Paolo Bonzini MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: [PATCH 19/19] migration: add a parser to accept FT migration incoming mode. References: <1296199312-26334-1-git-send-email-tamura.yoshiaki@lab.ntt.co.jp> <1296199312-26334-20-git-send-email-tamura.yoshiaki@lab.ntt.co.jp> <4D42BD7D.8020004@redhat.com> <4D42D601.9010905@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Yoshiaki Tamura Cc: kwolf@redhat.com, aliguori@us.ibm.com, mtosatti@redhat.com, ananth@in.ibm.com, kvm@vger.kernel.org, mst@redhat.com, dlaor@redhat.com, qemu-devel@nongnu.org, vatsa@linux.vnet.ibm.com, blauwirbel@gmail.com, ohmura.kei@lab.ntt.co.jp, avi@redhat.com, psuriset@linux.vnet.ibm.com, stefanha@linux.vnet.ibm.com On 01/28/2011 04:05 PM, Yoshiaki Tamura wrote: > Having a scheme like "kemari:tcp:host:port" looks quite > challenging to me. We can of course add some quick hacks for it, > but adding a nice layered architecture should be more > appropriate. Similar to protocols and formats in block layer? > At the same time, I want to avoid anything over engineered. I was simply thinking of if (strstart (uri, "kemari:", &p)) { ft_mode = FT_INIT; uri = p; } :) I think the same could be done for outgoing migration instead of -k actually. Paolo