From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755044Ab1A2XBE (ORCPT ); Sat, 29 Jan 2011 18:01:04 -0500 Received: from moutng.kundenserver.de ([212.227.126.187]:53026 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751813Ab1A2XBC (ORCPT ); Sat, 29 Jan 2011 18:01:02 -0500 Message-ID: <4D449C28.90202@weilnetz.de> Date: Sun, 30 Jan 2011 00:00:56 +0100 From: Stefan Weil User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.16) Gecko/20101226 Iceowl/1.0b1 Icedove/3.0.11 MIME-Version: 1.0 To: Jesper Juhl CC: linux390@de.ibm.com, Ursula Braun , Frank Blaschka , Martin Schwidefsky , Heiko Carstens , linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] s390: Fix possibly wrong size in strncmp (smsglucv) References: <1296336808-2809-1-git-send-email-weil@mail.berlios.de> <1296336808-2809-2-git-send-email-weil@mail.berlios.de> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V02:K0:unR0OYdeHk1YHfpjeYFzJdZzHtTnvzE1795asAPmCfl zgM7ux7DubR205T91FjTT+ZTu3EAgxelPszdsyu+nfOTp0IMYT ZlbjhHG1zRrTuyfg31onngjCtinKJAj08eDKyEi/G8DBCSsyw7 U5is0TJxqb+zi/PquyTjHGlgHht+ZtqjI1FKKLpJbouC9irXIo t4AY+oNzO7bLlMSDmBOy9KEOh5dknZ4aNNNB6yfhm+IjDjUrdH RxoG2VFxyxehU Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 29.01.2011 22:38, schrieb Jesper Juhl: > On Sat, 29 Jan 2011, Stefan Weil wrote: > > >> This error was reported by cppcheck: >> drivers/s390/net/smsgiucv.c:63: error: Using sizeof for array given as function argument returns the size of pointer. >> >> Although there is no runtime problem as long as sizeof(u8 *) == 8, >> this misleading code should get fixed. >> >> Cc: Ursula Braun >> Cc: linux390@de.ibm.com >> Cc: Frank Blaschka >> Cc: Martin Schwidefsky >> Cc: Heiko Carstens >> Cc: linux-s390@vger.kernel.org >> Cc: linux-kernel@vger.kernel.org >> Signed-off-by: Stefan Weil >> --- >> drivers/s390/net/smsgiucv.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/drivers/s390/net/smsgiucv.c b/drivers/s390/net/smsgiucv.c >> index 65e1cf1..207b7d7 100644 >> --- a/drivers/s390/net/smsgiucv.c >> +++ b/drivers/s390/net/smsgiucv.c >> @@ -60,7 +60,7 @@ static struct iucv_handler smsg_handler = { >> static int smsg_path_pending(struct iucv_path *path, u8 ipvmid[8], >> u8 ipuser[16]) >> { >> - if (strncmp(ipvmid, "*MSG ", sizeof(ipvmid)) != 0) >> + if (strncmp(ipvmid, "*MSG ", 8) != 0) >> > Hmm, shouldn't this really be ARRAY_SIZE(ipvmid) ?? > I think that would be wrong, too (only in this special case where an array is passed as a function parameter).