From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 05/29] nVMX: Implement reading and writing of VMX MSRs Date: Mon, 31 Jan 2011 11:01:45 +0200 Message-ID: <4D467A79.8010309@redhat.com> References: <1296116987-nyh@il.ibm.com> <201101270832.p0R8WOxe002432@rice.haifa.ibm.com> <4D4534E0.7010500@redhat.com> <20110131085753.GA23022@fermat.math.technion.ac.il> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, gleb@redhat.com To: "Nadav Har'El" Return-path: Received: from mx1.redhat.com ([209.132.183.28]:11301 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751249Ab1AaJBz (ORCPT ); Mon, 31 Jan 2011 04:01:55 -0500 In-Reply-To: <20110131085753.GA23022@fermat.math.technion.ac.il> Sender: kvm-owner@vger.kernel.org List-ID: On 01/31/2011 10:57 AM, Nadav Har'El wrote: > On Sun, Jan 30, 2011, Avi Kivity wrote about "Re: [PATCH 05/29] nVMX: Implement reading and writing of VMX MSRs": > > >+ case MSR_IA32_VMX_TRUE_PINBASED_CTLS: > > >+ case MSR_IA32_VMX_PINBASED_CTLS: > > >+ vmx_msr_low = CORE2_PINBASED_CTLS_MUST_BE_ONE; > > >+ vmx_msr_high = CORE2_PINBASED_CTLS_MUST_BE_ONE | > > >+ PIN_BASED_EXT_INTR_MASK | > > >+ PIN_BASED_NMI_EXITING | > > >+ PIN_BASED_VIRTUAL_NMIS; > > > > Can we actually support PIN_BASED_VIRTUAL_NMIs on hosts which don't > > support them? > > > > Maybe better to drop for the initial version. > > Thanks, I'll look into this. You already found this problem in June, and > it's already in my bugzilla. Just wanted to let you know that I'm taking > all your previous comments seriously, and not forgetting any of them. > Since you mention this one again, I'm increasing its priority, so I'll fix > it before the next version of the patches. Thanks. Since I see many other comments are still unaddressed, I'll stop reviewing until you let me know that you have a version that is ready for review. -- error compiling committee.c: too many arguments to function