From: Ben Greear <greearb@candelatech.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211: Recalculate channel-type on iface removal.
Date: Mon, 31 Jan 2011 10:48:54 -0800 [thread overview]
Message-ID: <4D470416.9020403@candelatech.com> (raw)
In-Reply-To: <1296499462.3812.41.camel@jlt3.sipsolutions.net>
On 01/31/2011 10:44 AM, Johannes Berg wrote:
> On Mon, 2011-01-31 at 10:37 -0800, greearb@candelatech.com wrote:
>
>> Also, use WARN_ON_ONCE instead of WARN_ON if user has
>> ht40- stations in conjunction with ht40+. It's not
>> really a kernel bug, just a mis-configuration of the
>> user's wifi environment.
>
> But how did we end up here to start with -- shouldn't that have been
> rejected?
The set-channel-type logic will complain, and I imagine the interfaces
will bounce around and attempt to re-associate, but I think it can
get into the mixed state.
Regardless of that, it may be something more mundane where we have
some HT-40 and HT-20 interfaces that can co-exist, but one of those
leaves. We should still re-calculate in case their leaving changes
the super-chan calculation.
Thanks,
Ben
>
> johannes
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
next prev parent reply other threads:[~2011-01-31 18:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-31 18:37 [PATCH] mac80211: Recalculate channel-type on iface removal greearb
2011-01-31 18:44 ` Johannes Berg
2011-01-31 18:48 ` Ben Greear [this message]
2011-01-31 18:57 ` Johannes Berg
2011-01-31 19:04 ` Ben Greear
2011-01-31 19:12 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D470416.9020403@candelatech.com \
--to=greearb@candelatech.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.