From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=57144 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PkHLY-0000rI-FM for qemu-devel@nongnu.org; Tue, 01 Feb 2011 09:36:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PkHLU-0008KY-O0 for qemu-devel@nongnu.org; Tue, 01 Feb 2011 09:36:41 -0500 Received: from mx1.redhat.com ([209.132.183.28]:44062) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PkHLU-0008KO-Et for qemu-devel@nongnu.org; Tue, 01 Feb 2011 09:36:40 -0500 Message-ID: <4D481A73.7040006@redhat.com> Date: Tue, 01 Feb 2011 15:36:35 +0100 From: Jes Sorensen MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 1/2] Add virtagent file system freeze/thaw References: <1296557928-30019-1-git-send-email-Jes.Sorensen@redhat.com> <1296557928-30019-2-git-send-email-Jes.Sorensen@redhat.com> <4D48182E.9030201@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: agl@us.ibm.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com On 02/01/11 15:34, Stefan Hajnoczi wrote: > On Tue, Feb 1, 2011 at 2:26 PM, Jes Sorensen wrote: >> I have to admit you lost me here, where do you get that 500ms time from? >> Is that the XMLRPC polling time or? I just used the example code from >> other agent calls. > > 500 ms is made up. I was thinking, "what would a reasonable polling > interval be?" and picked a sub-second number. > > Can you explain how the timeout in fsfreeze can happen? It's probably > because I don't know the virtagent details. Ah ok. >>From what I understand, the XMLRPC code is setup to timeout if the guest doesn't reply within a certain amount of time. In that case, the caller needs to poll to wait for the guest to complete the freeze. This really should only happen if you have a guest with a large number of very large file systems. I don't know how likely it is to happen in real life. Cheers, Jes