From: Bart De Schuymer <bdschuym@pandora.be>
To: Pierre Chifflier <chifflier@edenwall.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: WIP/RFC: add new module ebt_NFQUEUE for ebtables
Date: Thu, 03 Feb 2011 21:19:41 +0100 [thread overview]
Message-ID: <4D4B0DDD.5090703@pandora.be> (raw)
In-Reply-To: <1296743540-8148-1-git-send-email-chifflier@edenwall.com>
Op 3/02/2011 15:32, Pierre Chifflier schreef:
> Hi,
>
> Here is the code as requested for the module I'm trying to add.
> Basically, the code is split in two parts:
> - patch 1 and 2 prepare the ebtables and nfqueue existing code to allow
> sending packets from ebtables. Since these packets are labelled PF_BRIDGE
> they have no afinfo structure, so we just ignore (instead of exiting)
> - patch 3 adds the new module, which just always returns EBT_QUEUE
>
> This is of course not meant for inclusion, but comments would be welcome.
>
I'm not too familiar with nf_queue, but I don't see you register a queue
handler for NFPROTO_BRIDGE.
Why does __nf_queue even queue the packet to userspace if you didn't
register a queue handler for pf=NFPROTO_BRIDGE?
For debugging, you could experiment with iptables' queue target for
bridged IP traffic (iptables can be enabled to see bridged traffic)...
Since the queueing is basically done in the same bridge context for this
traffic, it should help you.
Bart
--
Bart De Schuymer
www.artinalgorithms.be
next prev parent reply other threads:[~2011-02-03 20:24 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-24 20:55 ebtables_nfqueue: missing structure afinfo Pierre Chifflier
2011-01-25 10:34 ` Patrick McHardy
2011-02-02 19:22 ` Pierre Chifflier
2011-02-02 22:59 ` Patrick McHardy
2011-02-03 14:32 ` WIP/RFC: add new module ebt_NFQUEUE for ebtables Pierre Chifflier
2011-02-03 20:19 ` Bart De Schuymer [this message]
2011-02-04 10:05 ` Pierre Chifflier
2011-02-04 13:07 ` Patrick McHardy
2011-02-04 13:20 ` Pierre Chifflier
2011-02-04 13:21 ` Patrick McHardy
2011-02-03 14:32 ` [PATCH 1/3] Make the afinfo structure optional in nf_queue and nf_reinject Pierre Chifflier
2011-02-04 13:27 ` Patrick McHardy
2011-02-04 14:15 ` Pierre Chifflier
2011-02-03 14:32 ` [PATCH 2/3] bridge: add support for the EBT_QUEUE target Pierre Chifflier
2011-02-03 14:32 ` [PATCH 3/3] bridge: add new target NFQUEUE for ebtables Pierre Chifflier
2011-02-04 13:25 ` Patrick McHardy
2011-02-04 13:40 ` Pierre Chifflier
2011-02-04 13:41 ` Patrick McHardy
[not found] ` <4D5104C4.3010105@edenwall.com>
[not found] ` <4D59C047.5050404@trash.net>
2011-02-16 16:57 ` [RFH] " Pierre Chifflier
2011-02-17 10:47 ` Patrick McHardy
2011-02-17 13:37 ` Pierre Chifflier
2011-02-18 13:42 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D4B0DDD.5090703@pandora.be \
--to=bdschuym@pandora.be \
--cc=chifflier@edenwall.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.