From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=51614 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PlPIy-0001IB-Pb
	for qemu-devel@nongnu.org; Fri, 04 Feb 2011 12:18:45 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <weil@mail.berlios.de>) id 1PlPIx-0003Jz-JG
	for qemu-devel@nongnu.org; Fri, 04 Feb 2011 12:18:44 -0500
Received: from moutng.kundenserver.de ([212.227.126.186]:57244)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <weil@mail.berlios.de>) id 1PlPIx-0003J0-84
	for qemu-devel@nongnu.org; Fri, 04 Feb 2011 12:18:43 -0500
Message-ID: <4D4C34E6.7070008@mail.berlios.de>
Date: Fri, 04 Feb 2011 18:18:30 +0100
From: Stefan Weil <weil@mail.berlios.de>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PING 0.14] Missing patches (mostly fixes)
References: <4D412CF0.30706@redhat.com>
	<4D49B04F.80201@mail.berlios.de>	<4D4BF160.9040500@codemonkey.ws>
	<m3ei7nvmz1.fsf@blackfin.pond.sub.org>
In-Reply-To: <m3ei7nvmz1.fsf@blackfin.pond.sub.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Anthony Liguori <aliguori@us.ibm.com>, "Michael S. Tsirkin" <mst@redhat.com>, Riku Voipio <riku.voipio@iki.fi>, Alexander Graf <agraf@suse.de>, qemu-devel <qemu-devel@nongnu.org>, Blue Swirl <blauwirbel@gmail.com>, Gerd Hoffmann <kraxel@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>

Am 04.02.2011 16:27, schrieb Markus Armbruster:
> Anthony Liguori <anthony@codemonkey.ws> writes:
>
>> On 02/02/2011 01:28 PM, Stefan Weil wrote:
> [...]
>>> [PATCH 1/3] tests: Fix two memory leaks
>>> (http://patchwork.ozlabs.org/patch/79945/)
>
>>> [PATCH 2/3] check-qdict: Fix possible crash
>>> (http://patchwork.ozlabs.org/patch/79946/)
>>
>> Luiz
>
> I wouldn't bother with the second one for 0.14. Yes, we're reading
> lines from a file with %s, but it's a fixed file with known contents, no
> long lines, and we're reading it in a test program only developers ever
> use.
>
> As to the first one, Luiz has never touched that file. Neither have I,
> and it's not obvious to me why it should go into 0.14.
>
> [...]

Even if the current code does not result in a real bug at the moment,
it should get fixed:

* Using tools like cppcheck (or others) to find bugs is good,
   because it finds bugs which are important.
   Sorting out "unimportant" bugs from the results wastes time
   which could be invested better, and this waste of time lasts
   forever until the "unimportant" bug will be fixed. The sooner
   you fix it, the better it is.

* Code gets copied, and maybe the copy of code with some weakness
   can expose a real problem.

Therefore I think that both patches should be applied
at least to qemu master (as they are really simple patches,
applying them to 0.14 would be cheap and good as well).

Regards,
Stefan Weil