From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=37497 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PlPw7-00079h-Us
	for qemu-devel@nongnu.org; Fri, 04 Feb 2011 12:59:12 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1PlPw6-0003eC-Hl
	for qemu-devel@nongnu.org; Fri, 04 Feb 2011 12:59:11 -0500
Received: from mail-vx0-f173.google.com ([209.85.220.173]:45631)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1PlPw6-0003e2-B1
	for qemu-devel@nongnu.org; Fri, 04 Feb 2011 12:59:10 -0500
Received: by vxb40 with SMTP id 40so790913vxb.4
	for <qemu-devel@nongnu.org>; Fri, 04 Feb 2011 09:59:09 -0800 (PST)
Message-ID: <4D4C3E66.3080709@codemonkey.ws>
Date: Fri, 04 Feb 2011 11:59:02 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PING 0.14] Missing patches (mostly fixes)
References: <4D412CF0.30706@redhat.com>	<4D49B04F.80201@mail.berlios.de>	<4D4BF160.9040500@codemonkey.ws>	<m3ei7nvmz1.fsf@blackfin.pond.sub.org>	<4D4C34E6.7070008@mail.berlios.de>
	<4D4C35B2.9010801@codemonkey.ws> <4D4C3927.6090400@mail.berlios.de>
In-Reply-To: <4D4C3927.6090400@mail.berlios.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <weil@mail.berlios.de>
Cc: Kevin Wolf <kwolf@redhat.com>, Anthony Liguori <aliguori@us.ibm.com>, "Michael S. Tsirkin" <mst@redhat.com>, Markus Armbruster <armbru@redhat.com>, Riku Voipio <riku.voipio@iki.fi>, qemu-devel <qemu-devel@nongnu.org>, Alexander Graf <agraf@suse.de>, Blue Swirl <blauwirbel@gmail.com>, Gerd Hoffmann <kraxel@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>

On 02/04/2011 11:36 AM, Stefan Weil wrote:
> Hi Anthony,
>
> please accept that even if you said something multiple times,
> other people might have a different point of view.

Yup, just making my point of view clear.

> QEMU is team work, isn't it?
>
> Both positives are correct, there was no false positive:
>
> Reading strings from external files into limited memory
> without limiting their length is bad. Even if it works with
> some input data, this kind of programming will be copied
> by novice programmers and used with data which is critical.

This is why I dislike patches like this, because the discussion about 
whether it really is important or not ends up being a huge distraction.

Regards,

Anthony Liguori