From: John Hughes <john@Calva.COM>
To: Andy Whitcroft <apw@canonical.com>
Cc: Andrew Hendry <andrew.hendry@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
linux-x25@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
Tim Gardner <tim.gardner@canonical.com>
Subject: Re: x25: possible skb leak on bad facilities
Date: Mon, 07 Feb 2011 10:25:29 +0100 [thread overview]
Message-ID: <4D4FBA89.606@Calva.COM> (raw)
In-Reply-To: <20110131130826.GC16804@shadowen.org>
On 31/01/11 14:08, Andy Whitcroft wrote:
> Looking at the changes introduced in the commit below, we seem to
> introduce an skb leak when a packet with bad facilities are present:
>
> commit a6331d6f9a4298173b413cf99a40cc86a9d92c37
> Author: andrew hendry<andrew.hendry@gmail.com>
> Date: Wed Nov 3 12:54:53 2010 +0000
>
> memory corruption in X.25 facilities parsing
>
> If I am understanding things correctly then we trigger a -1 return to
> the main packet dispatch loop, this being non-zero implies that we have
> requeued the skb and it should not be freed. As it was not requeued,
> I believe the skb is no longer referenced and then is leaked.
>
> Perhaps someone better aquainted with this code could review my analysis
> in the patch leader below. If accurate I believe we need the patch below
> to resolve this. If it is not then I suspect a comment is required on
> the -1 return.
>
> Thoughts?
>
Sadly, after nearly 30 years (1982-2010) we've just closed our last X.25
line so I can no longer test this.
Sorry.
prev parent reply other threads:[~2011-02-07 9:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-31 13:08 x25: possible skb leak on bad facilities Andy Whitcroft
2011-01-31 13:08 ` Andy Whitcroft
2011-02-01 11:55 ` Andrew Hendry
2011-02-07 4:28 ` David Miller
2011-02-07 6:29 ` Andrew Hendry
2011-02-07 10:08 ` Andrew Hendry
2011-02-07 21:42 ` David Miller
2011-02-07 9:25 ` John Hughes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D4FBA89.606@Calva.COM \
--to=john@calva.com \
--cc=andrew.hendry@gmail.com \
--cc=apw@canonical.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-x25@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tim.gardner@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.