From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Tokarev Subject: Re: [regression] KVM: hangs and "irq timeout" booting HURD unless -no-kvm-irqchip passed Date: Tue, 08 Feb 2011 10:40:00 +0300 Message-ID: <4D50F350.4050406@msgid.tls.msk.ru> References: <1283171743-10766-1-git-send-email-avi@redhat.com> <1283171743-10766-2-git-send-email-avi@redhat.com> <20110207060030.GA1896@elie> <4D4FE7E5.2040308@redhat.com> <20110207124513.GB14984@redhat.com> <20110207132729.GC14984@redhat.com> <20110208014032.GB1858@elie> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Gleb Natapov , Avi Kivity , Marcelo Tosatti , kvm@vger.kernel.org, Guillem Jover To: Jonathan Nieder Return-path: Received: from isrv.corpit.ru ([86.62.121.231]:43620 "EHLO isrv.corpit.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751951Ab1BHHkD (ORCPT ); Tue, 8 Feb 2011 02:40:03 -0500 In-Reply-To: <20110208014032.GB1858@elie> Sender: kvm-owner@vger.kernel.org List-ID: 08.02.2011 04:40, Jonathan Nieder wrote: > Gleb Natapov wrote: > >> Is this patch helps? >> >> diff --git a/arch/x86/kvm/i8259.c b/arch/x86/kvm/i8259.c >> index 3cece05..62b1dde 100644 >> --- a/arch/x86/kvm/i8259.c >> +++ b/arch/x86/kvm/i8259.c >> @@ -549,6 +549,9 @@ static void pic_irq_request(struct kvm *kvm, int level) >> struct kvm_pic *s = pic_irqchip(kvm); >> int irq = pic_get_irq(&s->pics[0]); >> >> + if (s->output && !level) >> + s->pics[0].isr_ack = 0xff; >> + > > Yes, it does (tested on top of kvm/master). Thanks! And FWIW, I still can't trigger this issue on my machines - with any of my custom kernels (2.6.37 and 2.6.38git included), but debian 2.6.37-trunk-amd64 triggers it. On all my kernels hurd installation goes way further. /mjt