From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=51730 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PmjSF-0002ng-9H for qemu-devel@nongnu.org; Tue, 08 Feb 2011 04:01:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PmjSE-0000Eh-8l for qemu-devel@nongnu.org; Tue, 08 Feb 2011 04:01:47 -0500 Received: from mail-ww0-f53.google.com ([74.125.82.53]:49954) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PmjSE-0000EX-3K for qemu-devel@nongnu.org; Tue, 08 Feb 2011 04:01:46 -0500 Received: by wwi18 with SMTP id 18so5404628wwi.10 for ; Tue, 08 Feb 2011 01:01:45 -0800 (PST) Message-ID: <4D510673.7020505@codemonkey.ws> Date: Tue, 08 Feb 2011 03:01:39 -0600 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: [PATCH 1/7] io-thread: make sure to initialize qemu_work_cond and qemu_cpu_cond References: <1295902845-29807-1-git-send-email-aliguori@us.ibm.com> <1295902845-29807-2-git-send-email-aliguori@us.ibm.com> <4D510490.8080201@siemens.com> In-Reply-To: <4D510490.8080201@siemens.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: Stefan Hajnoczi , Marcelo Tosatti , qemu-devel@nongnu.org, Paul Brook , Paulo Bonzini , Arun Bharadwaj On 02/08/2011 02:53 AM, Jan Kiszka wrote: > On 2011-01-24 22:00, Anthony Liguori wrote: > >> Signed-off-by: Anthony Liguori >> >> diff --git a/cpus.c b/cpus.c >> index 0309189..9cf7e6e 100644 >> --- a/cpus.c >> +++ b/cpus.c >> @@ -412,8 +412,10 @@ int qemu_init_main_loop(void) >> if (ret) >> return ret; >> >> - qemu_cond_init(&qemu_pause_cond); >> + qemu_cond_init(&qemu_cpu_cond); >> qemu_cond_init(&qemu_system_cond); >> + qemu_cond_init(&qemu_pause_cond); >> + qemu_cond_init(&qemu_work_cond); >> qemu_mutex_init(&qemu_fair_mutex); >> qemu_mutex_init(&qemu_global_mutex); >> qemu_mutex_lock(&qemu_global_mutex); >> > Please merge this independently of the glib patches. It's apparently > harmless only by chance so far. > Plan is to merge the first and second patch of the series right after 0.14.0 is released. Regards, Anthony Liguori > Thanks, > Jan > >