All of lore.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Gleb Natapov <gleb@redhat.com>,
	Jonathan Nieder <jrnieder@gmail.com>,
	kvm@vger.kernel.org, Michael Tokarev <mjt@tls.msk.ru>,
	Guillem Jover <guillem@debian.org>
Subject: Re: [regression] KVM: hangs and "irq timeout" booting HURD unless -no-kvm-irqchip passed
Date: Tue, 08 Feb 2011 16:43:33 +0200	[thread overview]
Message-ID: <4D515695.5080600@redhat.com> (raw)
In-Reply-To: <20110208142253.GA8243@amt.cnet>

On 02/08/2011 04:22 PM, Marcelo Tosatti wrote:
> I don't think the isr_ack logic is overly complex that it should be
> removed. For some cases it is still beneficial, see example case on
> commit e48258009d941, which is not handled by kick coalescing of
> kvm_vcpu_kick.

On the other hand, I think it can be done differently.  For example LVT0 
is probably programmed to mask interrupts; we can simply look at it and 
not kick if that's the case.  We can use notifiers from the lapic to the 
pic to avoid looking at lapic data.

The advantage in this way is that we avoid introducing state, instead 
relying on existing state.  New state is always bad since it has to be 
kept in sync with guest visible state.

-- 
error compiling committee.c: too many arguments to function


  parent reply	other threads:[~2011-02-08 14:43 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-30 12:35 [PATCH v5 0/5] Nonatomic interrupt injection Avi Kivity
2010-08-30 12:35 ` [PATCH v5 1/5] KVM: Check for pending events before attempting injection Avi Kivity
2011-02-07  6:00   ` [regression] KVM: hangs and "irq timeout" booting HURD unless -no-kvm-irqchip passed Jonathan Nieder
2011-02-07 12:39     ` Avi Kivity
2011-02-07 12:45       ` Gleb Natapov
2011-02-07 13:27         ` Gleb Natapov
2011-02-08  1:40           ` Jonathan Nieder
2011-02-08  7:40             ` Michael Tokarev
2011-02-08 12:00             ` Gleb Natapov
2011-02-08 14:22               ` Marcelo Tosatti
2011-02-08 14:41                 ` Gleb Natapov
2011-02-08 14:43                 ` Avi Kivity [this message]
2011-02-08 14:47                   ` Gleb Natapov
2011-02-08 14:57                     ` Avi Kivity
2011-02-08 17:44                       ` Marcelo Tosatti
2011-02-08 20:40               ` Jonathan Nieder
2010-08-30 12:35 ` [PATCH v5 2/5] KVM: VMX: Split up vmx_complete_interrupts() Avi Kivity
2010-08-30 12:35 ` [PATCH v5 3/5] KVM: VMX: Move real-mode interrupt injection fixup to vmx_complete_interrupts() Avi Kivity
2010-08-30 12:35 ` [PATCH v5 4/5] KVM: VMX: Parameterize vmx_complete_interrupts() for both exit and entry Avi Kivity
2010-08-30 12:35 ` [PATCH v5 5/5] KVM: Non-atomic interrupt injection Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D515695.5080600@redhat.com \
    --to=avi@redhat.com \
    --cc=gleb@redhat.com \
    --cc=guillem@debian.org \
    --cc=jrnieder@gmail.com \
    --cc=kvm@vger.kernel.org \
    --cc=mjt@tls.msk.ru \
    --cc=mtosatti@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.